From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE3DC77B77 for ; Thu, 13 Apr 2023 16:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbjDMQkI (ORCPT ); Thu, 13 Apr 2023 12:40:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjDMQkH (ORCPT ); Thu, 13 Apr 2023 12:40:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D876B8A6A; Thu, 13 Apr 2023 09:40:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6777663FDC; Thu, 13 Apr 2023 16:40:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3CEFC433D2; Thu, 13 Apr 2023 16:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681404005; bh=izUZnBlpqKhrOemjMQlQ/aNyVeCCaykBq9pZH8LYzrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mV172mFxB6ZMZj/kTDxvU7GqmLSM12EClHuQSW9+FuPWrJS/8sOoVp1TRoMGOQhzg tgrAzRwK0kn1rShHFmuT2uOliRUnt//OiRyUzH7CTqpqpwNnzYT1ShurwRaspSx5sq rErIjVUEdJKqX43Eszo93ZV3/wxPW9KTZDXD7F7Xio39CkEKpzg6LtqNbuYxsZzXNw D9rc9DtIFZFtftUAYjjsxwG5JwpiLFYXLN4hTj85yeshtmq6gWbfCwb0ICNytfaww4 s1W6K9wEhE1BF97kaZZVIuH1svXoX0QMuwzArhkqJ5PKzrKY9tQ+NeTifiSm0uxT9f 3gMT0Nfl+4zlw== Date: Thu, 13 Apr 2023 09:40:03 -0700 From: Jakub Kicinski To: Leon Romanovsky Cc: Haiyang Zhang , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , Dexuan Cui , KY Srinivasan , Paul Rosswurm , "olaf@aepfle.de" , "vkuznets@redhat.com" , "davem@davemloft.net" , "wei.liu@kernel.org" , "edumazet@google.com" , "pabeni@redhat.com" , Long Li , "ssengar@linux.microsoft.com" , "linux-rdma@vger.kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "bpf@vger.kernel.org" , "ast@kernel.org" , Ajay Sharma , "hawk@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU Message-ID: <20230413094003.3fa4cd8c@kernel.org> In-Reply-To: <20230413163059.GS17993@unreal> References: <1681334163-31084-1-git-send-email-haiyangz@microsoft.com> <1681334163-31084-3-git-send-email-haiyangz@microsoft.com> <20230413130428.GO17993@unreal> <20230413163059.GS17993@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 13 Apr 2023 19:30:59 +0300 Leon Romanovsky wrote: > > So the page pool is optimized for the XDP, and that sentence is applicable to drivers > > that have set up page pool for XDP optimization. > > "but it can fallback on the regular page allocator APIs." The XDP thing is historic AFAIU, page_pool has been expanded to cover all uses cases, and is "just better" (tm) than using page allocator directly. Maybe we should update the doc.