From: Christoph Hellwig <hch@lst.de>
To: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 1/3] net: Ensure ->msg_control_user is used for user buffers
Date: Thu, 13 Apr 2023 16:08:10 +0200 [thread overview]
Message-ID: <20230413140810.GC16625@lst.de> (raw)
In-Reply-To: <20230413114705.157046-2-kevin.brodsky@arm.com>
On Thu, Apr 13, 2023 at 12:47:03PM +0100, Kevin Brodsky wrote:
> Since commit 1f466e1f15cf ("net: cleanly handle kernel vs user
> buffers for ->msg_control"), pointers to user buffers should be
> stored in struct msghdr::msg_control_user, instead of the
> msg_control field. Most users of msg_control have already been
> converted (where user buffers are involved), but not all of them.
>
> This patch attempts to address the remaining cases. An exception is
> made for null checks, as it should be safe to use msg_control
> unconditionally for that purpose.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
although I would have expected this at the end of the series. Given
that the patches don't overlap it shouldn't really matter in the end,
though.
next prev parent reply other threads:[~2023-04-13 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 11:47 [PATCH v2 0/3] net: Finish up ->msg_control{,_user} split Kevin Brodsky
2023-04-13 11:47 ` [PATCH v2 1/3] net: Ensure ->msg_control_user is used for user buffers Kevin Brodsky
2023-04-13 14:08 ` Christoph Hellwig [this message]
2023-04-13 11:47 ` [PATCH v2 2/3] net/compat: Update msg_control_is_user when setting a kernel pointer Kevin Brodsky
2023-04-13 14:07 ` Christoph Hellwig
2023-04-13 11:47 ` [PATCH v2 3/3] net/ipv6: Initialise msg_control_is_user Kevin Brodsky
2023-04-13 14:07 ` Christoph Hellwig
2023-04-14 10:30 ` [PATCH v2 0/3] net: Finish up ->msg_control{,_user} split patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413140810.GC16625@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kevin.brodsky@arm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).