From: Yixin Shen <bobankhshen@gmail.com>
To: leon@kernel.org
Cc: akpm@linux-foundation.org, bobankhshen@gmail.com,
davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, ncardwell@google.com,
netdev@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH net-next] lib/win_minmax: export symbol of minmax_running_min
Date: Fri, 14 Apr 2023 02:27:36 +0000 [thread overview]
Message-ID: <20230414022736.63374-1-bobankhshen@gmail.com> (raw)
In-Reply-To: <20230413171918.GX17993@unreal>
> Please provide in-tree kernel user for that EXPORT_SYMBOL.
It is hard to provide such an in-tree kernel user. We are trying to
implement newer congestion control algorithms as dynamically loaded modules.
For example, Copa(NSDI'18) which is adopted by Facebook needs to maintain
such windowed min filters. Althought it is true that we can just
copy-and-paste the code inside lib/win_minmax, it it more convenient to
give the same status of minmax_running_min as minmax_running_max.
It is confusing that only minmax_running_max is exported.
If this patch is rejected because the changes are too significant,
I can also understand.
Thanks.
next prev parent reply other threads:[~2023-04-14 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 16:47 [PATCH net-next] lib/win_minmax: export symbol of minmax_running_min Yixin Shen
2023-04-13 17:19 ` Leon Romanovsky
2023-04-14 2:27 ` Yixin Shen [this message]
2023-04-14 9:00 ` Leon Romanovsky
2023-04-14 14:17 ` Eric Dumazet
2023-04-14 21:20 ` Andrew Morton
2023-04-14 15:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414022736.63374-1-bobankhshen@gmail.com \
--to=bobankhshen@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).