From: Jakub Kicinski <kuba@kernel.org>
To: Emeel Hakim <ehakim@nvidia.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<sd@queasysnail.net>, <netdev@vger.kernel.org>, <leon@kernel.org>
Subject: Re: [PATCH net-next v5 5/5] macsec: Don't rely solely on the dst MAC address to identify destination MACsec device
Date: Fri, 14 Apr 2023 08:00:51 -0700 [thread overview]
Message-ID: <20230414080051.004e2a67@kernel.org> (raw)
In-Reply-To: <20230413105622.32697-6-ehakim@nvidia.com>
On Thu, 13 Apr 2023 13:56:22 +0300 Emeel Hakim wrote:
> + struct macsec_rx_sc *rx_sc = (md_dst && md_dst->type == METADATA_MACSEC) ?
> + find_rx_sc(&macsec->secy,
> + md_dst->u.macsec_info.sci) : NULL;
Just a coding nit, in addition to Subbaraya's question:
why use a ternary operator if the entire expression ends up being
3 lines of code? :| And well above 80 char.
next prev parent reply other threads:[~2023-04-14 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 10:56 [PATCH net-next v5 0/5] Support MACsec VLAN Emeel Hakim
2023-04-13 10:56 ` [PATCH net-next v5 1/5] vlan: Add MACsec offload operations for VLAN interface Emeel Hakim
2023-04-13 10:56 ` [PATCH net-next v5 2/5] net/mlx5: Enable MACsec offload feature " Emeel Hakim
2023-04-13 10:56 ` [PATCH net-next v5 3/5] net/mlx5: Support MACsec over VLAN Emeel Hakim
2023-04-13 10:56 ` [PATCH net-next v5 4/5] net/mlx5: Consider VLAN interface in MACsec TX steering rules Emeel Hakim
2023-04-13 10:56 ` [PATCH net-next v5 5/5] macsec: Don't rely solely on the dst MAC address to identify destination MACsec device Emeel Hakim
2023-04-14 6:32 ` Subbaraya Sundeep Bhatta
2023-04-16 12:14 ` Emeel Hakim
2023-04-17 17:37 ` Subbaraya Sundeep Bhatta
2023-04-18 7:05 ` Emeel Hakim
2023-04-18 10:48 ` Sabrina Dubroca
2023-04-18 14:35 ` Subbaraya Sundeep Bhatta
2023-04-14 15:00 ` Jakub Kicinski [this message]
2023-04-16 12:18 ` Emeel Hakim
2023-04-17 18:04 ` Jakub Kicinski
2023-04-13 22:48 ` [PATCH net-next v5 0/5] Support MACsec VLAN Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414080051.004e2a67@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).