From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH next-next v3 0/3] extend drop reasons
Date: Fri, 14 Apr 2023 19:20:34 -0700 [thread overview]
Message-ID: <20230414192034.23d40371@kernel.org> (raw)
In-Reply-To: <20230414182219.7d0dd0bd@kernel.org>
On Fri, 14 Apr 2023 18:22:19 -0700 Jakub Kicinski wrote:
> FWIW:
>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
I take that back :)
This:
> + /** @SKB_DROP_REASON_SUBSYS_MASK: subsystem mask in drop reasons,
> + * see &enum skb_drop_reason_subsys
> + */
is not valid kdoc, confusingly.
If it's longer than one line, the /** has to be on an otherwise empty line.
Run the new files thru ./scripts/kernel-doc -none, perhaps.
next prev parent reply other threads:[~2023-04-15 2:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 15:12 [PATCH next-next v3 0/3] extend drop reasons Johannes Berg
2023-04-14 15:12 ` [PATCH next-next v3 1/3] net: move dropreason.h to dropreason-core.h Johannes Berg
2023-04-14 15:12 ` [PATCH next-next v3 2/3] net: extend drop reasons for multiple subsystems Johannes Berg
2023-04-14 15:12 ` [PATCH next-next v3 3/3] mac80211: use the new drop reasons infrastructure Johannes Berg
2023-04-15 1:22 ` [PATCH next-next v3 0/3] extend drop reasons Jakub Kicinski
2023-04-15 2:20 ` Jakub Kicinski [this message]
2023-04-18 9:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414192034.23d40371@kernel.org \
--to=kuba@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).