From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC02C77B71 for ; Fri, 14 Apr 2023 21:06:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjDNVGx (ORCPT ); Fri, 14 Apr 2023 17:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbjDNVGx (ORCPT ); Fri, 14 Apr 2023 17:06:53 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F04CA9B for ; Fri, 14 Apr 2023 14:06:51 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1pnQd2-0004Hd-EW; Fri, 14 Apr 2023 23:06:44 +0200 Date: Fri, 14 Apr 2023 23:06:44 +0200 From: Florian Westphal To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, pablo@netfilter.org, fw@strlen.de Subject: Re: [PATCH net-next 4/5] net: skbuff: push nf_trace down the bitfield Message-ID: <20230414210644.GB5927@breakpoint.cc> References: <20230414160105.172125-1-kuba@kernel.org> <20230414160105.172125-5-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414160105.172125-5-kuba@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jakub Kicinski wrote: > nf_trace is a debug feature, AFAIU, and yet it sits oddly > high in the sk_buff bitfield. Move it down, pushing up > dst_pending_confirm and inner_protocol_type. Yes, its a debug feature and can be moved. Acked-by: Florian Westphal