From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FAF8C77B72 for ; Fri, 14 Apr 2023 21:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbjDNVJz (ORCPT ); Fri, 14 Apr 2023 17:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjDNVJy (ORCPT ); Fri, 14 Apr 2023 17:09:54 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6630D4EF2 for ; Fri, 14 Apr 2023 14:09:53 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1pnQg2-0004K3-40; Fri, 14 Apr 2023 23:09:50 +0200 Date: Fri, 14 Apr 2023 23:09:50 +0200 From: Florian Westphal To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, pablo@netfilter.org, fw@strlen.de Subject: Re: [PATCH net-next 5/5] net: skbuff: hide nf_trace and ipvs_property Message-ID: <20230414210950.GC5927@breakpoint.cc> References: <20230414160105.172125-1-kuba@kernel.org> <20230414160105.172125-6-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414160105.172125-6-kuba@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jakub Kicinski wrote: > Accesses to nf_trace and ipvs_property are already wrapped > by ifdefs where necessary. Don't allocate the bits for those > fields at all if possible. > > Signed-off-by: Jakub Kicinski > --- > CC: pablo@netfilter.org > CC: fw@strlen.de > --- > include/linux/skbuff.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 543f7ae9f09f..7b43d5a03613 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -966,8 +966,12 @@ struct sk_buff { > __u8 ndisc_nodetype:2; > #endif > > +#if IS_ENABLED(CONFIG_IP_VS) > __u8 ipvs_property:1; > +#endif > +#if IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TRACE) || defined(CONFIG_NF_TABLES) > __u8 nf_trace:1; As already pointed out nftables can be a module, other than that Acked-by: Florian Westphal