From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFCA4C77B73 for ; Sat, 15 Apr 2023 22:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229946AbjDOW46 (ORCPT ); Sat, 15 Apr 2023 18:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjDOW44 (ORCPT ); Sat, 15 Apr 2023 18:56:56 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DF412D59 for ; Sat, 15 Apr 2023 15:56:55 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id v9so27349990pjk.0 for ; Sat, 15 Apr 2023 15:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1681599414; x=1684191414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ubRjxle8AfL59Prm/wkmTmVjb75/p8iBeRuuijtLjNg=; b=TZKMN8poAHP4YwAqnU9eEVSOlb5ek8a5pOp6pAenCZDEHOJssxaf+A4++1IIYw7MpM 7aq9yaEQTpQNruGixDOeSiEIZuumGKqQqq61OfoKbml+6JwtYe2rw4/T/V8o5iEBSi51 OSOWCMJ+FlQaNG/1ktYx6rTm4HSd8b8EpSnbipfzd+GjNGowid2Q/djKv2jOWWHaHmEP hSiqOIeyIH6QSf2ALrjHP/WGwHSsfWJFwgnpnRFGR3vBzTBTPXI+33kdhOkhQoB8hegE UeeIqG5sqAzmDiUPg8p1YaOLplu+Tnxv7+bB8KIo23tQvL0qQzEtGCfEbteC9xiY3pS+ pioA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681599414; x=1684191414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubRjxle8AfL59Prm/wkmTmVjb75/p8iBeRuuijtLjNg=; b=GRV7E3wSYQr+4BbfFXnjIjmji0Pd895ufvWdm5tDktGor5Y8us+nFh8EzpDEW9gY9s z6NmTWksS18pbvqUdgatLyhpQ8O4BvSHYryOxsAmKJovoLiyOyvziCmizZmcbWGAePL+ 31Pa6hOPKbq4ChZiOYpRBHEuIl+8noGQOgcoIuL7nbPyT1lsPAG80rrDEWDEIVlr+HV+ /tZoyfK4yU78xTPrD0hq0b3bzuI1fTNybVGFUiiVqGWKpysNRm78T1xDw+pRGAyCbivM mNb0C6hNwZlKzkddIz/V6ILMr4KHx/UIiCbKuBjgd3U1lBqt7VKlTrgo7ygqOJ80Oegm wEmw== X-Gm-Message-State: AAQBX9eU2KuP7VvrN4hQVdSypBB8AFkpmQHPTbVbyTmsh/EXKY4lm/rP 6ngP4WdBic5JKmpOA0RRnGRfAA== X-Google-Smtp-Source: AKy350bsEaGCTirqACeAVtm48St3ie5XE0fYZj2D3HWUz1dZxDWvNItGbUZOV8DjHKhZt7C3oJG6Eg== X-Received: by 2002:a05:6a20:78a8:b0:e9:5b0a:deff with SMTP id d40-20020a056a2078a800b000e95b0adeffmr9990865pzg.22.1681599414582; Sat, 15 Apr 2023 15:56:54 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e25-20020a635019000000b00502e6bfedc0sm4647359pgb.0.2023.04.15.15.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 15:56:54 -0700 (PDT) Date: Sat, 15 Apr 2023 15:56:51 -0700 From: Stephen Hemminger To: david.keisarschm@mail.huji.ac.il Cc: linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alan Stern , Andrea Parri , Will Deacon , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , Joel Fernandes , Jason@zx2c4.com, keescook@chromium.org, ilay.bahat1@gmail.com, aksecurity@gmail.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v5 3/3] Replace invocation of weak PRNG Message-ID: <20230415155651.18ce590f@hermes.local> In-Reply-To: <20230415173756.5520-1-david.keisarschm@mail.huji.ac.il> References: <20230415173756.5520-1-david.keisarschm@mail.huji.ac.il> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 15 Apr 2023 20:37:53 +0300 david.keisarschm@mail.huji.ac.il wrote: > diff --git a/include/uapi/linux/netfilter/xt_dscp.h b/include/uapi/linux/netfilter/xt_dscp.h > index 7594e4df8..223d635e8 100644 > --- a/include/uapi/linux/netfilter/xt_dscp.h > +++ b/include/uapi/linux/netfilter/xt_dscp.h > @@ -1,32 +1,27 @@ > /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > -/* x_tables module for matching the IPv4/IPv6 DSCP field > +/* x_tables module for setting the IPv4/IPv6 DSCP field > * > * (C) 2002 Harald Welte > + * based on ipt_FTOS.c (C) 2000 by Matthew G. Marsh > * This software is distributed under GNU GPL v2, 1991 > * > * See RFC2474 for a description of the DSCP field within the IP Header. > * > - * xt_dscp.h,v 1.3 2002/08/05 19:00:21 laforge Exp > + * xt_DSCP.h,v 1.7 2002/03/14 12:03:13 laforge Exp > */ This part of the change is a mess. Why are you adding ipt_FTOS.c here? Why are you updating ancient header line from 2002?