From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB48CC77B76 for ; Sun, 16 Apr 2023 22:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbjDPWnU (ORCPT ); Sun, 16 Apr 2023 18:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjDPWnU (ORCPT ); Sun, 16 Apr 2023 18:43:20 -0400 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C1341BDD; Sun, 16 Apr 2023 15:43:19 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id C769E20187; Mon, 17 Apr 2023 00:43:17 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vX8EeMPoLeKL; Mon, 17 Apr 2023 00:43:17 +0200 (CEST) Received: from begin.home (apoitiers-658-1-118-253.w92-162.abo.wanadoo.fr [92.162.65.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 5F97F20186; Mon, 17 Apr 2023 00:43:17 +0200 (CEST) Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1poB5Y-003fMu-2g; Mon, 17 Apr 2023 00:43:16 +0200 Date: Mon, 17 Apr 2023 00:43:16 +0200 From: Samuel Thibault To: Dominique Martinet Cc: James Chapman , tparkin@katalix.com, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PPPoL2TP: Add more code snippets Message-ID: <20230416224316.xlvgjor65nejldwh@begin> Mail-Followup-To: Samuel Thibault , Dominique Martinet , James Chapman , tparkin@katalix.com, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230416220704.xqk4q6uwjbujnqpv@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dominique Martinet, le lun. 17 avril 2023 07:26:41 +0900, a ecrit: > > +The ppp interface can then be configured as usual with SIOCSIFMTU, > > +SIOCSIFADDR, SIOCSIFDSTADDR, SIOCSIFNETMASK, and activated by setting IFF_UP > > +with SIOCSIFFLAGS > > (That somewhat makes it sounds like the "new" netlink interface cannot > be used (e.g. ip command); Ah, right... > although I guess sommeone implementing this would be more likely to > use the ioctls than not so having the names can be a timesaver?) It's indeed a timesaver to have the ioctl names, but perhaps we can replace this part with a pointer to a if-configuration documentation? > Also, this got me wondering if the 'if' fd can be closed immediately or > if the interface will be removed when the fd is closed (probably not?) Closing the fd would close the if, yes. AIUI one really has to keep the pppox socket (for stats), the ppp chan (for non-data ppp packets), and the ppp if (for the if). Samuel