From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE79C77B76 for ; Mon, 17 Apr 2023 06:44:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbjDQGoa (ORCPT ); Mon, 17 Apr 2023 02:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbjDQGo3 (ORCPT ); Mon, 17 Apr 2023 02:44:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B67AD1BB for ; Sun, 16 Apr 2023 23:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681713822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HU6O3KzfQ0zQunJtU8XAVLCiL1L8OjBQOXvK0FwCmb0=; b=SfSaXI7i9rolakEjO4owKe4TQSpiewGYwgn4phOkST6c0iDXFrCOJ9zBRZRFo2dUFyS5nY WEpGPSEQieH5MKV9yTv08M7ntAhfe7GghzrDabyjWU9CvDXogZ6utBlWdn152uLD7ctkUm EtD3h91YUA8n9pIqZ05FXWc/8Fhd45s= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-8-V0kRlVN12ELg1KyBncRw-1; Mon, 17 Apr 2023 02:43:41 -0400 X-MC-Unique: 8-V0kRlVN12ELg1KyBncRw-1 Received: by mail-qt1-f197.google.com with SMTP id t27-20020a05622a181b00b003ef334999bfso316766qtc.5 for ; Sun, 16 Apr 2023 23:43:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681713821; x=1684305821; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HU6O3KzfQ0zQunJtU8XAVLCiL1L8OjBQOXvK0FwCmb0=; b=OlcZhkcurJ3tb20PRbLP635l2uu4JmYjwezP+sVBnPeWrtdsNzr8eO+1tWdNe6WgQp EqwtMaL4rKwlXnBJEvnJjpILJ1FCdj9HtqSxOGci0WX74IhuMzG0Md6xlazs/se4lF4F qWkjMTvdMQ7Tm3FnSPHbYt+2btyIWE3TPvOTDaukIYenZ4B57d+7Q0d2CpoBvRU1+7MG zWnSfqi721n67ykvdsjyOVfzVGz8xh1g9lQsRhro3BXzCN/vh6m0uyESJOa9JggGcQgO HT6ZQTERALgkLxfeSfPNAAgXPyuN3KAdV7KclkcTunBC7N73OoPPEgSaRO2KdGEHd77j jvMA== X-Gm-Message-State: AAQBX9fyNaKS+Jx4TnSTapPfY+WLfXsJAZHnVKrbNVqsUy8j6Dwbt2B9 YKMMyb0D7T9ENd5miClsuko5rOzOzz+rrxmluFmXA4ru0Bp6YYXWhQ7YbHhHOqD/75HhkXST5So C5B7j/BliRX9FoLxZ X-Received: by 2002:a05:622a:1756:b0:3bf:d8b6:4ca1 with SMTP id l22-20020a05622a175600b003bfd8b64ca1mr20925363qtk.28.1681713821389; Sun, 16 Apr 2023 23:43:41 -0700 (PDT) X-Google-Smtp-Source: AKy350aze/kYu2ExuJQuREbYNzivfTsLWddfaCb28LVbISLKnDjQ8eKYMKUloj0ytrzWgoKdCDYq1w== X-Received: by 2002:a05:622a:1756:b0:3bf:d8b6:4ca1 with SMTP id l22-20020a05622a175600b003bfd8b64ca1mr20925333qtk.28.1681713821133; Sun, 16 Apr 2023 23:43:41 -0700 (PDT) Received: from redhat.com ([185.199.103.251]) by smtp.gmail.com with ESMTPSA id ay43-20020a05620a17ab00b0074577e835f2sm2985905qkb.48.2023.04.16.23.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 23:43:40 -0700 (PDT) Date: Mon, 17 Apr 2023 02:43:32 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: netdev@vger.kernel.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , bpf@vger.kernel.org, virtualization@lists.linux-foundation.org, Jason Wang , Guenter Roeck , Gerd Hoffmann , Christoph Hellwig Subject: Re: [PATCH net-next] xsk: introduce xsk_dma_ops Message-ID: <20230417024216-mutt-send-email-mst@kernel.org> References: <20230417032750.7086-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417032750.7086-1-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 17, 2023 at 11:27:50AM +0800, Xuan Zhuo wrote: > @@ -532,9 +545,9 @@ struct xdp_buff *xp_alloc(struct xsk_buff_pool *pool) > xskb->xdp.data_meta = xskb->xdp.data; > > if (pool->dma_need_sync) { > - dma_sync_single_range_for_device(pool->dev, xskb->dma, 0, > - pool->frame_len, > - DMA_BIDIRECTIONAL); > + pool->dma_ops.sync_single_range_for_device(pool->dev, xskb->dma, 0, > + pool->frame_len, > + DMA_BIDIRECTIONAL); > } > return &xskb->xdp; > } > @@ -670,15 +683,15 @@ EXPORT_SYMBOL(xp_raw_get_dma); > > void xp_dma_sync_for_cpu_slow(struct xdp_buff_xsk *xskb) > { > - dma_sync_single_range_for_cpu(xskb->pool->dev, xskb->dma, 0, > - xskb->pool->frame_len, DMA_BIDIRECTIONAL); > + xskb->pool->dma_ops.sync_single_range_for_cpu(xskb->pool->dev, xskb->dma, 0, > + xskb->pool->frame_len, DMA_BIDIRECTIONAL); > } > EXPORT_SYMBOL(xp_dma_sync_for_cpu_slow); > > void xp_dma_sync_for_device_slow(struct xsk_buff_pool *pool, dma_addr_t dma, > size_t size) > { > - dma_sync_single_range_for_device(pool->dev, dma, 0, > - size, DMA_BIDIRECTIONAL); > + pool->dma_ops.sync_single_range_for_device(pool->dev, dma, 0, > + size, DMA_BIDIRECTIONAL); > } > EXPORT_SYMBOL(xp_dma_sync_for_device_slow); So you add an indirect function call on data path? Won't this be costly? > -- > 2.32.0.3.g01195cf9f