From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, hawk@kernel.org,
ilias.apalodimas@linaro.org, davem@davemloft.net,
pabeni@redhat.com, bpf@vger.kernel.org,
lorenzo.bianconi@redhat.com, nbd@nbd.name
Subject: Re: issue with inflight pages from page_pool
Date: Mon, 17 Apr 2023 11:23:46 -0700 [thread overview]
Message-ID: <20230417112346.546dbe57@kernel.org> (raw)
In-Reply-To: <ZD2NSSYFzNeN68NO@lore-desk>
On Mon, 17 Apr 2023 20:17:45 +0200 Lorenzo Bianconi wrote:
> > I do not see why this would be different than having buffers sitting
> > in some tcp receive
> > (or out or order) queues for a few minutes ?
>
> The main issue in my tests (and even in mt76 I think) is the pages are not returned
> to the pool for a very long time (even hours) and doing so the pool is like in a
> 'limbo' state where it is not actually deallocated and page_pool_release_retry
> continues complaining about it. I think this is because we do not have more tcp
> traffic to deallocate them, but I am not so familiar with tcp codebase :)
I've seen the page leaks too in my recent testing but I just assumed
I fumbled the quick bnxt conversion to page pool. Could it be something
with page frags? It happened a lot if I used page frags, IIRC mt76 is
using page frags, too.
Is drgn available for your target? You could try to scan the pages on
the system and see if you can find what's still pointing to the page
pool (assuming they are indeed leaked and not returned to the page
allocator without releasing :()
next prev parent reply other threads:[~2023-04-17 18:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 17:53 issue with inflight pages from page_pool Lorenzo Bianconi
2023-04-17 18:08 ` Eric Dumazet
2023-04-17 18:17 ` Lorenzo Bianconi
2023-04-17 18:23 ` Jakub Kicinski [this message]
2023-04-17 18:42 ` Lorenzo Bianconi
2023-04-17 19:08 ` Jakub Kicinski
2023-04-17 21:31 ` Lorenzo Bianconi
2023-04-17 23:32 ` Jakub Kicinski
2023-04-18 7:36 ` Lorenzo Bianconi
2023-04-19 11:08 ` Jesper Dangaard Brouer
2023-04-19 12:09 ` Eric Dumazet
2023-04-19 14:02 ` Jesper Dangaard Brouer
2023-04-19 14:18 ` Eric Dumazet
2023-04-19 16:10 ` Jesper Dangaard Brouer
2023-04-19 14:21 ` Lorenzo Bianconi
2023-04-19 15:36 ` Jesper Dangaard Brouer
2023-04-19 16:40 ` Lorenzo Bianconi
2023-04-19 17:12 ` Jakub Kicinski
2023-04-17 18:24 ` Gerhard Engleder
2023-04-17 19:00 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417112346.546dbe57@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).