From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: "Christoph Hellwig" <hch@infradead.org>,
netdev@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
bpf@vger.kernel.org, virtualization@lists.linux-foundation.org,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH net-next] xsk: introduce xsk_dma_ops
Date: Mon, 17 Apr 2023 11:56:10 -0700 [thread overview]
Message-ID: <20230417115610.7763a87c@kernel.org> (raw)
In-Reply-To: <1681711081.378984-2-xuanzhuo@linux.alibaba.com>
On Mon, 17 Apr 2023 13:58:01 +0800 Xuan Zhuo wrote:
> On Sun, 16 Apr 2023 21:24:32 -0700, Christoph Hellwig <hch@infradead.org> wrote:
> > On Mon, Apr 17, 2023 at 11:27:50AM +0800, Xuan Zhuo wrote:
> > > The purpose of this patch is to allow driver pass the own dma_ops to
> > > xsk.
> >
> > Drivers have no business passing around dma_ops, or even knowing about
> > them.
>
> May misunderstand, here the "dma_ops" is not the "dma_ops" of DMA API.
>
> I mean the callbacks for xsk to do dma.
>
> Maybe, I should rename it in the next version.
Would you mind explaining this a bit more to folks like me who are not
familiar with VirtIO? DMA API is supposed to hide the DMA mapping
details from the stack, why is it not sufficient here.
next prev parent reply other threads:[~2023-04-17 18:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 3:27 [PATCH net-next] xsk: introduce xsk_dma_ops Xuan Zhuo
2023-04-17 4:24 ` Christoph Hellwig
2023-04-17 5:58 ` Xuan Zhuo
2023-04-17 18:56 ` Jakub Kicinski [this message]
2023-04-17 18:57 ` Jakub Kicinski
2023-04-18 1:07 ` Jason Wang
2023-04-18 1:19 ` Jakub Kicinski
2023-04-18 2:19 ` Xuan Zhuo
2023-04-18 2:54 ` Jakub Kicinski
2023-04-18 5:01 ` Christoph Hellwig
2023-04-18 6:19 ` Jakub Kicinski
2023-04-19 5:16 ` Christoph Hellwig
2023-04-19 13:14 ` Alexander Lobakin
2023-04-19 13:40 ` Xuan Zhuo
2023-04-20 6:16 ` Christoph Hellwig
2023-04-20 13:59 ` Alexander Lobakin
2023-04-20 16:15 ` Christoph Hellwig
2023-04-20 16:42 ` Alexander Lobakin
2023-05-01 4:28 ` Christoph Hellwig
2023-04-19 16:45 ` Jakub Kicinski
2023-04-20 6:19 ` Christoph Hellwig
2023-04-20 9:11 ` Xuan Zhuo
2023-04-20 16:18 ` Christoph Hellwig
2023-04-25 8:12 ` Michael S. Tsirkin
2023-05-01 4:16 ` Christoph Hellwig
2023-04-20 14:13 ` Jakub Kicinski
2023-04-21 7:31 ` Xuan Zhuo
2023-04-21 13:50 ` Jakub Kicinski
2023-04-23 1:54 ` Xuan Zhuo
2023-04-24 15:28 ` Jakub Kicinski
2023-04-24 15:28 ` Alexander Lobakin
2023-04-25 2:11 ` Xuan Zhuo
2023-04-18 2:15 ` Xuan Zhuo
2023-04-17 6:38 ` kernel test robot
2023-04-17 6:43 ` Michael S. Tsirkin
2023-04-17 6:48 ` Xuan Zhuo
2023-04-17 6:48 ` kernel test robot
2023-04-19 13:22 ` Alexander Lobakin
2023-04-19 13:42 ` Xuan Zhuo
2023-04-20 6:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417115610.7763a87c@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kraxel@redhat.com \
--cc=linux@roeck-us.net \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).