From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91DDC77B75 for ; Tue, 18 Apr 2023 22:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbjDRWwV (ORCPT ); Tue, 18 Apr 2023 18:52:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjDRWwU (ORCPT ); Tue, 18 Apr 2023 18:52:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF1BD1FFE; Tue, 18 Apr 2023 15:52:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FF4F62C8F; Tue, 18 Apr 2023 22:52:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF57C433EF; Tue, 18 Apr 2023 22:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681858336; bh=de+HR91aylZyjaPhYykVk5+9J82pw/GilutzW+IbEZA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a9k6pUklOiFdFWtJKWwtr3E5csuPk8CJsxJV2jv14DpS0shBJK4sLGqGwlYtxoatw SRlz/b90fX46Qj96NsUT2Do7/DkaOFOJmpTnxbKqxIXcgQXz0Y3dvhIajF7d4IawPZ tUb3dvRd2eoyThZRlNpl8CO7SdU7GuqopSIC1vjKf0M2+nEcUWkK23pxSODPBdiVuY 7pFL8+CywdVSHXKzFsrICNjUzSujPHrr3PL+dfjFGMzdiHoouiqSZ4/z34EdR5jBdf SRAULUzq9r3/DvbaJlWZqWlOkBwnd7mpoRFLaXbmSUfC+V7Q3I3x9B+cknZg9DE1lQ DHVj7YzZgljNw== Date: Tue, 18 Apr 2023 15:52:15 -0700 From: Jakub Kicinski To: Gencen Gan Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: amd: Fix link leak when verifying config failed Message-ID: <20230418155215.24e7e140@kernel.org> In-Reply-To: <20230417144750.3976715-1-gangecen@hust.edu.cn> References: <20230417144750.3976715-1-gangecen@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 17 Apr 2023 22:47:50 +0800 Gencen Gan wrote: > From: Gecen Gan > > After failing to verify configuration, it returns directly without > releasing link, which may cause memory leak. > > Signed-off-by: Gecen Gan > --- > drivers/net/ethernet/amd/nmclan_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c > index 823a329a921f..0dd391c84c13 100644 > --- a/drivers/net/ethernet/amd/nmclan_cs.c > +++ b/drivers/net/ethernet/amd/nmclan_cs.c > @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link) > } else { > pr_notice("mace id not found: %x %x should be 0x40 0x?9\n", > sig[0], sig[1]); > - return -ENODEV; > + goto failed; > } > } The patch looks whitespace-damaged, it doesn't apply cleanly. AFAICT there is one space missing in the indentation. Probably your email server is doing something funny to it. -- pw-bot: cr