* [PATCH] net: amd: Fix link leak when verifying config failed
@ 2023-04-17 14:47 Gencen Gan
2023-04-18 22:52 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Gencen Gan @ 2023-04-17 14:47 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Gecen Gan, netdev, linux-kernel
From: Gecen Gan <gangecen@hust.edu.cn>
After failing to verify configuration, it returns directly without
releasing link, which may cause memory leak.
Signed-off-by: Gecen Gan <gangecen@hust.edu.cn>
---
drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
index 823a329a921f..0dd391c84c13 100644
--- a/drivers/net/ethernet/amd/nmclan_cs.c
+++ b/drivers/net/ethernet/amd/nmclan_cs.c
@@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
} else {
pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
sig[0], sig[1]);
- return -ENODEV;
+ goto failed;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: amd: Fix link leak when verifying config failed
2023-04-17 14:47 [PATCH] net: amd: Fix link leak when verifying config failed Gencen Gan
@ 2023-04-18 22:52 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-04-18 22:52 UTC (permalink / raw)
To: Gencen Gan
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, netdev, linux-kernel
On Mon, 17 Apr 2023 22:47:50 +0800 Gencen Gan wrote:
> From: Gecen Gan <gangecen@hust.edu.cn>
>
> After failing to verify configuration, it returns directly without
> releasing link, which may cause memory leak.
>
> Signed-off-by: Gecen Gan <gangecen@hust.edu.cn>
> ---
> drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
> index 823a329a921f..0dd391c84c13 100644
> --- a/drivers/net/ethernet/amd/nmclan_cs.c
> +++ b/drivers/net/ethernet/amd/nmclan_cs.c
> @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
> } else {
> pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
> sig[0], sig[1]);
> - return -ENODEV;
> + goto failed;
> }
> }
The patch looks whitespace-damaged, it doesn't apply cleanly.
AFAICT there is one space missing in the indentation.
Probably your email server is doing something funny to it.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-18 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-17 14:47 [PATCH] net: amd: Fix link leak when verifying config failed Gencen Gan
2023-04-18 22:52 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).