From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: [PATCHv5 net-next] bonding: add software tx timestamping support
Date: Tue, 18 Apr 2023 21:17:46 -0700 [thread overview]
Message-ID: <20230418211746.2aa60760@kernel.org> (raw)
In-Reply-To: <ZD9pbffw3s1HVwvE@Laptop-X1>
On Wed, 19 Apr 2023 12:09:17 +0800 Hangbin Liu wrote:
> > I'll apply Jay's ack from v4 since these are not substantial changes.
> > Thanks!
>
> Sorry, not sure if I missed something. bond_ethtool_get_ts_info() could be
> called without RTNL. And we have ASSERT_RTNL() in v4.
Are there any documented best practices on when to keep an ack?
I'm not aware of such a doc, it's a bit of a gray zone.
IMHO the changes here weren't big enough to drop Jay's tag.
next prev parent reply other threads:[~2023-04-19 4:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 3:48 [PATCHv5 net-next] bonding: add software tx timestamping support Hangbin Liu
2023-04-19 3:50 ` Jakub Kicinski
2023-04-19 4:09 ` Hangbin Liu
2023-04-19 4:17 ` Jakub Kicinski [this message]
2023-04-19 4:44 ` Jay Vosburgh
2023-04-19 6:04 ` Hangbin Liu
2023-04-19 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418211746.2aa60760@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).