From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
brouer@redhat.com, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, hawk@kernel.org,
ilias.apalodimas@linaro.org, davem@davemloft.net,
pabeni@redhat.com, bpf@vger.kernel.org,
lorenzo.bianconi@redhat.com, nbd@nbd.name,
Toke Hoiland Jorgensen <toke@redhat.com>
Subject: Re: issue with inflight pages from page_pool
Date: Wed, 19 Apr 2023 10:12:42 -0700 [thread overview]
Message-ID: <20230419101242.44f2d143@kernel.org> (raw)
In-Reply-To: <e8df2654-6a5b-3c92-489d-2fe5e444135f@redhat.com>
On Wed, 19 Apr 2023 17:36:20 +0200 Jesper Dangaard Brouer wrote:
> This reminds me that Jakub's recent defer patches returning pages
> 'directly' to the page_pool alloc-cache, will actually result in this
> kind of bug. This is because page_pool_destroy() assumes that pages
> cannot be returned to alloc-cache, as driver will have "disconnected" RX
> side. We need to address this bug separately.
Mm, I think you're right. The NAPI can get restarted with a different
page pool and the old page pool will still think it's in use.
next prev parent reply other threads:[~2023-04-19 17:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 17:53 issue with inflight pages from page_pool Lorenzo Bianconi
2023-04-17 18:08 ` Eric Dumazet
2023-04-17 18:17 ` Lorenzo Bianconi
2023-04-17 18:23 ` Jakub Kicinski
2023-04-17 18:42 ` Lorenzo Bianconi
2023-04-17 19:08 ` Jakub Kicinski
2023-04-17 21:31 ` Lorenzo Bianconi
2023-04-17 23:32 ` Jakub Kicinski
2023-04-18 7:36 ` Lorenzo Bianconi
2023-04-19 11:08 ` Jesper Dangaard Brouer
2023-04-19 12:09 ` Eric Dumazet
2023-04-19 14:02 ` Jesper Dangaard Brouer
2023-04-19 14:18 ` Eric Dumazet
2023-04-19 16:10 ` Jesper Dangaard Brouer
2023-04-19 14:21 ` Lorenzo Bianconi
2023-04-19 15:36 ` Jesper Dangaard Brouer
2023-04-19 16:40 ` Lorenzo Bianconi
2023-04-19 17:12 ` Jakub Kicinski [this message]
2023-04-17 18:24 ` Gerhard Engleder
2023-04-17 19:00 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419101242.44f2d143@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).