From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: daire.mcnamara@microchip.com, nicholas.ferre@microchip.com,
claudiu.beznea@microchip.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
conor.dooley@microchip.com
Subject: Re: [PATCH v2 1/1] net: macb: Shorten max_tx_len to 4KiB - 56 on mpfs
Date: Wed, 19 Apr 2023 18:02:22 -0700 [thread overview]
Message-ID: <20230419180222.07d78b8a@kernel.org> (raw)
In-Reply-To: <ZD6pCdvKdGAJsN3x@corigine.com>
On Tue, 18 Apr 2023 16:28:25 +0200 Simon Horman wrote:
> no need to refresh the patch on my account.
> But can the above be simplified as:
>
> if (macb_is_gem(bp) && hw_is_gem(bp->regs, bp->native_io))
> bp->max_tx_length = macb_config->max_tx_length;
> else
> bp->max_tx_length = MACB_MAX_TX_LEN;
I suspect that DaveM agreed, because patch is set to Changes Requested
in patchwork :)
Daire, please respin with Simon's suggestion.
next prev parent reply other threads:[~2023-04-20 1:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 14:00 [PATCH v2 0/1] Adjust macb max_tx_len for mpfs daire.mcnamara
2023-04-17 14:00 ` [PATCH v2 1/1] net: macb: Shorten max_tx_len to 4KiB - 56 on mpfs daire.mcnamara
2023-04-18 14:28 ` Simon Horman
2023-04-20 1:02 ` Jakub Kicinski [this message]
2023-04-20 7:18 ` Conor Dooley
2023-04-21 14:05 ` Simon Horman
2023-04-21 16:39 ` Conor Dooley
2023-04-21 17:43 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419180222.07d78b8a@kernel.org \
--to=kuba@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicholas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).