From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 1/4] net/sched: sch_htb: use extack on errors messages
Date: Wed, 19 Apr 2023 18:08:32 -0700 [thread overview]
Message-ID: <20230419180832.3f0b7729@kernel.org> (raw)
In-Reply-To: <20230417171218.333567-2-pctammela@mojatatu.com>
On Mon, 17 Apr 2023 14:12:15 -0300 Pedro Tammela wrote:
> @@ -1917,8 +1917,8 @@ static int htb_change_class(struct Qdisc *sch, u32 classid,
> };
> err = htb_offload(dev, &offload_opt);
> if (err) {
> - pr_err("htb: TC_HTB_LEAF_ALLOC_QUEUE failed with err = %d\n",
> - err);
> + NL_SET_ERR_MSG(extack,
> + "Failed to offload leaf alloc queue");
> goto err_kill_estimator;
> }
> dev_queue = netdev_get_tx_queue(dev, offload_opt.qid);
> @@ -1937,8 +1937,8 @@ static int htb_change_class(struct Qdisc *sch, u32 classid,
> };
> err = htb_offload(dev, &offload_opt);
> if (err) {
> - pr_err("htb: TC_HTB_LEAF_TO_INNER failed with err = %d\n",
> - err);
> + NL_SET_ERR_MSG(extack,
> + "Failed to offload leaf to inner");
I missed the message changes on v1, but since the patches are already
Changes Requested in patchwork...
IDK what TC_HTB_LEAF_TO_INNER is exactly, neither do I understand
"Failed to offload leaf to inner". The first one should be "Failed to
alloc offload leaf queue" if anything.
Let's just stick to the existing messages?
next prev parent reply other threads:[~2023-04-20 1:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 17:12 [PATCH net-next v2 0/4] net/sched: cleanup parsing prints in htb and qfq Pedro Tammela
2023-04-17 17:12 ` [PATCH net-next v2 1/4] net/sched: sch_htb: use extack on errors messages Pedro Tammela
2023-04-19 12:51 ` Simon Horman
2023-04-20 1:08 ` Jakub Kicinski [this message]
2023-04-20 2:14 ` Pedro Tammela
2023-04-20 14:17 ` Jakub Kicinski
2023-04-17 17:12 ` [PATCH net-next v2 2/4] net/sched: sch_qfq: " Pedro Tammela
2023-04-17 21:33 ` Jamal Hadi Salim
2023-04-19 12:52 ` Simon Horman
2023-04-17 17:12 ` [PATCH net-next v2 3/4] net/sched: sch_qfq: refactor parsing of netlink parameters Pedro Tammela
2023-04-19 12:53 ` Simon Horman
2023-04-17 17:12 ` [PATCH net-next v2 4/4] selftests: tc-testing: add more tests for sch_qfq Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419180832.3f0b7729@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).