From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3867AC6FD18 for ; Thu, 20 Apr 2023 01:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbjDTB6G (ORCPT ); Wed, 19 Apr 2023 21:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbjDTB6F (ORCPT ); Wed, 19 Apr 2023 21:58:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E305119 for ; Wed, 19 Apr 2023 18:58:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED7476445E for ; Thu, 20 Apr 2023 01:58:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDD4DC433D2; Thu, 20 Apr 2023 01:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681955884; bh=DdoJTMWNANHAZa+omh8su4PBjKCr4a1xPG4fOlBsxIc=; h=From:To:Cc:Subject:Date:From; b=W0r/Wta2mifbP3XBhxbA/ju5Yq1AwTBiWp3SFUD4BV/OOMtOPCsiGo9qy5wT/OdTq mmuPlLk6G8jcekzeeuCbk0FQWWds2ACttbjktHUgFxG/CQEJmwiSr84zW6JMAqsuVq cfeageeIZ2hD1T47DIkWjfpTJ5zp/UoJfHVhXVynbwvp9L9HX3bFMF6rmx1/F/zg3h 3NKFE0PlaUFItVi7GzSQH3nmqHM7pP/sqR3/lj+RbiEgpdrrlt4LZlMI5e/CeyNqCk x3vfvZt6Mg3+e0yMzlLgSnFsxXu0Tr65SzKx/nrAQF/UCu/I7UHnwI6xSh+GQT+Irh Uni/ZKYbIBZCA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, Jakub Kicinski , saeedm@nvidia.com, leon@kernel.org Subject: [PATCH net-next] eth: mlx5: avoid iterator use outside of a loop Date: Wed, 19 Apr 2023 18:58:02 -0700 Message-Id: <20230420015802.815362-1-kuba@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix the following warning about risky iterator use: drivers/net/ethernet/mellanox/mlx5/core/eq.c:1010 mlx5_comp_irq_get_affinity_mask() warn: iterator used outside loop: 'eq' Signed-off-by: Jakub Kicinski --- v2: - return NULL rather than 0 v1: https://lore.kernel.org/all/20230416101753.GB15386@unreal/ CC: saeedm@nvidia.com CC: leon@kernel.org --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c index eb41f0abf798..1c35d721a31d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c @@ -1070,10 +1070,11 @@ mlx5_comp_irq_get_affinity_mask(struct mlx5_core_dev *dev, int vector) list_for_each_entry(eq, &table->comp_eqs_list, list) { if (i++ == vector) - break; + return mlx5_irq_get_affinity_mask(eq->core.irq); } - return mlx5_irq_get_affinity_mask(eq->core.irq); + WARN_ON_ONCE(1); + return NULL; } EXPORT_SYMBOL(mlx5_comp_irq_get_affinity_mask); -- 2.39.2