[PATCH net-next] net: skbuff: update and rename __kfree_skb_defer()

[PATCH net-next] net: skbuff: update and rename __kfree_skb_defer()

[Jakub Kicinski]

__kfree_skb_defer() uses the old naming where "defer" meant
slab bulk free/alloc APIs. In the meantime we also made
__kfree_skb_defer() feed the per-NAPI skb cache, which
implies bulk APIs. So take away the 'defer' and add 'napi'.

While at it add a drop reason. This only matters on the
tx_action path, if the skb has a frag_list. But getting
rid of a SKB_DROP_REASON_NOT_SPECIFIED seems like a net
benefit so why not.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 include/linux/skbuff.h | 2 +-
 net/core/dev.c         | 3 ++-
 net/core/gro.c         | 2 +-
 net/core/skbuff.c      | 4 ++--
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 5f120bbab9da..6a77652ddd7e 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3252,7 +3252,7 @@ static inline struct sk_buff *napi_alloc_skb(struct napi_struct *napi,
 void napi_consume_skb(struct sk_buff *skb, int budget);
 
 void napi_skb_free_stolen_head(struct sk_buff *skb);
-void __kfree_skb_defer(struct sk_buff *skb);
+void __napi_kfree_skb(struct sk_buff *skb, enum skb_drop_reason reason);
 
 /**
  * __dev_alloc_pages - allocate page for network Rx
diff --git a/net/core/dev.c b/net/core/dev.c
index 3fc4dba71f9d..1551aabac343 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5040,7 +5040,8 @@ static __latent_entropy void net_tx_action(struct softirq_action *h)
 			if (skb->fclone != SKB_FCLONE_UNAVAILABLE)
 				__kfree_skb(skb);
 			else
-				__kfree_skb_defer(skb);
+				__napi_kfree_skb(skb,
+						 get_kfree_skb_cb(skb)->reason);
 		}
 	}
 
diff --git a/net/core/gro.c b/net/core/gro.c
index a606705a0859..2d84165cb4f1 100644
--- a/net/core/gro.c
+++ b/net/core/gro.c
@@ -633,7 +633,7 @@ static gro_result_t napi_skb_finish(struct napi_struct *napi,
 		else if (skb->fclone != SKB_FCLONE_UNAVAILABLE)
 			__kfree_skb(skb);
 		else
-			__kfree_skb_defer(skb);
+			__napi_kfree_skb(skb, SKB_CONSUMED);
 		break;
 
 	case GRO_HELD:
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 768f9d04911f..8764653bede7 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1226,9 +1226,9 @@ static void napi_skb_cache_put(struct sk_buff *skb)
 	}
 }
 
-void __kfree_skb_defer(struct sk_buff *skb)
+void __napi_kfree_skb(struct sk_buff *skb, enum skb_drop_reason reason)
 {
-	skb_release_all(skb, SKB_DROP_REASON_NOT_SPECIFIED, true);
+	skb_release_all(skb, reason, true);
 	napi_skb_cache_put(skb);
 }
 
-- 
2.39.2

Re: [PATCH net-next] net: skbuff: update and rename __kfree_skb_defer()

[Alexander Lobakin]

From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 19 Apr 2023 19:00:05 -0700

> __kfree_skb_defer() uses the old naming where "defer" meant
> slab bulk free/alloc APIs. In the meantime we also made
> __kfree_skb_defer() feed the per-NAPI skb cache, which
> implies bulk APIs. So take away the 'defer' and add 'napi'.
> 
> While at it add a drop reason. This only matters on the
> tx_action path, if the skb has a frag_list. But getting
> rid of a SKB_DROP_REASON_NOT_SPECIFIED seems like a net
> benefit so why not.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

[...]

Thanks,
Olek

Re: [PATCH net-next] net: skbuff: update and rename __kfree_skb_defer()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 19 Apr 2023 19:00:05 -0700 you wrote:
> __kfree_skb_defer() uses the old naming where "defer" meant
> slab bulk free/alloc APIs. In the meantime we also made
> __kfree_skb_defer() feed the per-NAPI skb cache, which
> implies bulk APIs. So take away the 'defer' and add 'napi'.
> 
> While at it add a drop reason. This only matters on the
> tx_action path, if the skb has a frag_list. But getting
> rid of a SKB_DROP_REASON_NOT_SPECIFIED seems like a net
> benefit so why not.
> 
> [...]

Here is the summary with links:
  - [net-next] net: skbuff: update and rename __kfree_skb_defer()
    https://git.kernel.org/netdev/net-next/c/8fa66e4a1bdd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html