From: "Köry Maincent" <kory.maincent@bootlin.com>
To: Max Georgiev <glipus@gmail.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
kuba@kernel.org, netdev@vger.kernel.org,
maxime.chevallier@bootlin.com, vadim.fedorenko@linux.dev,
richardcochran@gmail.com, gerhard@engleder-embedded.com
Subject: Re: [RFC PATCH v3 1/5] Add NDOs for hardware timestamp get/set
Date: Thu, 20 Apr 2023 16:16:09 +0200 [thread overview]
Message-ID: <20230420161609.2b65a1ed@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <CAP5jrPH__dJpGepM6Vs45PH+Pppx6KOVnUDS5f44DGeyseghfQ@mail.gmail.com>
On Wed, 5 Apr 2023 09:54:27 -0600
Max Georgiev <glipus@gmail.com> wrote:
> On Wed, Apr 5, 2023 at 6:31 AM Vladimir Oltean <vladimir.oltean@nxp.com>
> wrote:
> >
> > On Wed, Apr 05, 2023 at 12:31:44AM -0600, Maxim Georgiev wrote:
> > > Current NIC driver API demands drivers supporting hardware timestamping
> > > to implement handling logic for SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs.
> > > Handling these IOCTLs requires dirivers to implement request parameter
> > > structure translation between user and kernel address spaces, handling
> > > possible translation failures, etc. This translation code is pretty much
> > > identical across most of the NIC drivers that support SIOCGHWTSTAMP/
> > > SIOCSHWTSTAMP.
> > > This patch extends NDO functiuon set with ndo_hwtstamp_get/set
> > > functions, implements SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTL translation
> > > to ndo_hwtstamp_get/set function calls including parameter structure
> > > translation and translation error handling.
> > >
> > > This patch is sent out as RFC.
> > > It still pending on basic testing.
Just wondering about the status of this patch series.
Do you want hardware testing before v4?
As there were several reviews, I was waiting for the next version before doing
any testing but if you ask for it to move forward I can deal with it.
Also, I have cadence macb MAC which supports time stamping, I can adapt your
last patch on e1000e to macb driver but I would appreciate if you do it
beforehand.
next prev parent reply other threads:[~2023-04-20 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 6:31 [RFC PATCH v3 1/5] Add NDOs for hardware timestamp get/set Maxim Georgiev
2023-04-05 12:31 ` Vladimir Oltean
2023-04-05 15:54 ` Max Georgiev
2023-04-20 14:16 ` Köry Maincent [this message]
2023-04-20 18:04 ` Max Georgiev
2023-04-21 13:03 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420161609.2b65a1ed@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=gerhard@engleder-embedded.com \
--cc=glipus@gmail.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox