From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: Davide Caratti <dcaratti@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit"
Date: Thu, 20 Apr 2023 16:24:35 -0700 [thread overview]
Message-ID: <20230420162435.1d5a79df@kernel.org> (raw)
In-Reply-To: <4e8324cf-e6de-acff-5e30-373d015a3cb4@mojatatu.com>
On Thu, 20 Apr 2023 13:25:33 -0300 Pedro Tammela wrote:
> > "id": "9398",
> > "name": "Create FQ with maxrate setting",
>
> You probably don't want to backport the test as well? If so I would
> break this patch into two.
IIRC the preference of stable folks is to backport more not fewer
selftests. Practicality of that aside, I think the patch is good as is.
next prev parent reply other threads:[~2023-04-20 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 14:59 [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit" Davide Caratti
2023-04-20 16:25 ` Pedro Tammela
2023-04-20 23:24 ` Jakub Kicinski [this message]
2023-04-21 14:24 ` Pedro Tammela
2023-04-21 15:58 ` Davide Caratti
2023-04-22 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420162435.1d5a79df@kernel.org \
--to=kuba@kernel.org \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).