* Re: [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency
2023-04-20 21:36 [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency Arnd Bergmann
@ 2023-04-20 12:13 ` Christian Marangi
2023-04-20 18:59 ` Christian Marangi
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Christian Marangi @ 2023-04-20 12:13 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Arnd Bergmann, netdev,
linux-kernel
On Thu, Apr 20, 2023 at 11:36:31PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With LEDS_CLASS=m, a built-in qca8k driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
> qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
>
> Change the dependency to avoid the broken configuration.
>
> Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks a lot for the fix and sorry for the mess...
LED_CLASS and PHY releated were really hell also for some reason this
didn't got flagged in month of this series.
Again thanks for handling this!
--
Ansuel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency
2023-04-20 21:36 [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency Arnd Bergmann
2023-04-20 12:13 ` Christian Marangi
@ 2023-04-20 18:59 ` Christian Marangi
2023-04-21 12:46 ` Andrew Lunn
2023-04-22 3:30 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Christian Marangi @ 2023-04-20 18:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Arnd Bergmann, netdev,
linux-kernel
On Thu, Apr 20, 2023 at 11:36:31PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With LEDS_CLASS=m, a built-in qca8k driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
> qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
>
> Change the dependency to avoid the broken configuration.
>
> Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christian Marangi <ansuelsmth@gmail.com>
--
Ansuel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency
@ 2023-04-20 21:36 Arnd Bergmann
2023-04-20 12:13 ` Christian Marangi
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Arnd Bergmann @ 2023-04-20 21:36 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Christian Marangi
Cc: Arnd Bergmann, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
With LEDS_CLASS=m, a built-in qca8k driver fails to link:
arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
Change the dependency to avoid the broken configuration.
Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/dsa/qca/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca/Kconfig b/drivers/net/dsa/qca/Kconfig
index 7a86d6d6a246..4347b42c50fd 100644
--- a/drivers/net/dsa/qca/Kconfig
+++ b/drivers/net/dsa/qca/Kconfig
@@ -19,7 +19,7 @@ config NET_DSA_QCA8K
config NET_DSA_QCA8K_LEDS_SUPPORT
bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support"
depends on NET_DSA_QCA8K
- depends on LEDS_CLASS
+ depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K
help
This enabled support for LEDs present on the Qualcomm Atheros
QCA8K Ethernet switch chips.
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency
2023-04-20 21:36 [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency Arnd Bergmann
2023-04-20 12:13 ` Christian Marangi
2023-04-20 18:59 ` Christian Marangi
@ 2023-04-21 12:46 ` Andrew Lunn
2023-04-22 3:30 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2023-04-21 12:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Christian Marangi, Arnd Bergmann,
netdev, linux-kernel
On Thu, Apr 20, 2023 at 11:36:31PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With LEDS_CLASS=m, a built-in qca8k driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
> qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
>
> Change the dependency to avoid the broken configuration.
>
> Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency
2023-04-20 21:36 [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency Arnd Bergmann
` (2 preceding siblings ...)
2023-04-21 12:46 ` Andrew Lunn
@ 2023-04-22 3:30 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-22 3:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: andrew, f.fainelli, olteanv, davem, edumazet, kuba, pabeni,
ansuelsmth, arnd, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 20 Apr 2023 23:36:31 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With LEDS_CLASS=m, a built-in qca8k driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
> qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'
>
> [...]
Here is the summary with links:
- net: dsa: qca8k: fix LEDS_CLASS dependency
https://git.kernel.org/netdev/net-next/c/33c1af8e2c75
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-22 3:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-20 21:36 [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency Arnd Bergmann
2023-04-20 12:13 ` Christian Marangi
2023-04-20 18:59 ` Christian Marangi
2023-04-21 12:46 ` Andrew Lunn
2023-04-22 3:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).