* [PATCH] net: ethernet: mediatek: remove return value check of `mtk_wed_hw_add_debugfs`
@ 2023-04-21 15:10 Wang Zhang
2023-04-23 12:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wang Zhang @ 2023-04-21 15:10 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
Lorenzo Bianconi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno
Cc: hust-os-kernel-patches, Wang Zhang, Dongliang Mu, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Smatch complains that:
mtk_wed_hw_add_debugfs() warn: 'dir' is an error pointer or valid
Debugfs checks are generally not supposed to be checked
for errors and it is not necessary here.
fix it by just deleting the dead code.
Signed-off-by: Wang Zhang <silver_code@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
This issue is found by static analyzer. The patched code has passed
Smatch checker, but remains untested on mediatek soc.
---
drivers/net/ethernet/mediatek/mtk_wed_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c b/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c
index 56f663439721..b244c02c5b51 100644
--- a/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c
+++ b/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c
@@ -252,8 +252,6 @@ void mtk_wed_hw_add_debugfs(struct mtk_wed_hw *hw)
snprintf(hw->dirname, sizeof(hw->dirname), "wed%d", hw->index);
dir = debugfs_create_dir(hw->dirname, NULL);
- if (!dir)
- return;
hw->debugfs_dir = dir;
debugfs_create_u32("regidx", 0600, dir, &hw->debugfs_reg);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: mediatek: remove return value check of `mtk_wed_hw_add_debugfs`
2023-04-21 15:10 [PATCH] net: ethernet: mediatek: remove return value check of `mtk_wed_hw_add_debugfs` Wang Zhang
@ 2023-04-23 12:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-23 12:50 UTC (permalink / raw)
To: Wang Zhang
Cc: nbd, john, sean.wang, Mark-MC.Lee, lorenzo, davem, edumazet, kuba,
pabeni, matthias.bgg, angelogioacchino.delregno,
hust-os-kernel-patches, dzm91, netdev, linux-kernel,
linux-arm-kernel, linux-mediatek
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 21 Apr 2023 23:10:09 +0800 you wrote:
> Smatch complains that:
> mtk_wed_hw_add_debugfs() warn: 'dir' is an error pointer or valid
>
> Debugfs checks are generally not supposed to be checked
> for errors and it is not necessary here.
>
> fix it by just deleting the dead code.
>
> [...]
Here is the summary with links:
- net: ethernet: mediatek: remove return value check of `mtk_wed_hw_add_debugfs`
https://git.kernel.org/netdev/net/c/b148b9abc844
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-23 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-21 15:10 [PATCH] net: ethernet: mediatek: remove return value check of `mtk_wed_hw_add_debugfs` Wang Zhang
2023-04-23 12:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).