From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
simon.horman@corigine.com
Subject: Re: [PATCH net-next v4 0/4] net/sched: cleanup parsing prints in htb and qfq
Date: Fri, 21 Apr 2023 21:08:05 -0700 [thread overview]
Message-ID: <20230421210805.42a66c21@kernel.org> (raw)
In-Reply-To: <20230421175344.299496-1-pctammela@mojatatu.com>
On Fri, 21 Apr 2023 14:53:40 -0300 Pedro Tammela wrote:
> These two qdiscs are still using prints on dmesg to report parsing
> errors. Since the parsing code has access to extack, convert these error
> messages to extack.
>
> QFQ also had the opportunity to remove some redundant code in the
> parameters parsing by transforming some attributes into parsing
> policies.
I haven't investigated in detail but doesn't seem to apply:
Applying: net/sched: sch_htb: use extack on errors messages
Applying: net/sched: sch_qfq: use extack on errors messages
Applying: net/sched: sch_qfq: refactor parsing of netlink parameters
error: patch failed: net/sched/sch_qfq.c:408
error: net/sched/sch_qfq.c: patch does not apply
Patch failed at 0003 net/sched: sch_qfq: refactor parsing of netlink parameters
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
fatal: It looks like 'git am' is in progress. Cannot rebase.
--
pw-bot: cr
prev parent reply other threads:[~2023-04-22 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 17:53 [PATCH net-next v4 0/4] net/sched: cleanup parsing prints in htb and qfq Pedro Tammela
2023-04-21 17:53 ` [PATCH net-next v4 1/4] net/sched: sch_htb: use extack on errors messages Pedro Tammela
2023-04-21 17:53 ` [PATCH net-next v4 2/4] net/sched: sch_qfq: " Pedro Tammela
2023-04-21 17:53 ` [PATCH net-next v4 3/4] net/sched: sch_qfq: refactor parsing of netlink parameters Pedro Tammela
2023-04-21 17:53 ` [PATCH net-next v4 4/4] selftests: tc-testing: add more tests for sch_qfq Pedro Tammela
2023-04-22 4:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421210805.42a66c21@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=simon.horman@corigine.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).