From: Johan Hovold <johan+linaro@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 0/2] Bluetooth: fix debugfs registration
Date: Mon, 24 Apr 2023 14:48:50 +0200 [thread overview]
Message-ID: <20230424124852.12625-1-johan+linaro@kernel.org> (raw)
The HCI controller debugfs interface is created during setup or when a
controller is configured, but there is nothing preventing a controller
from being configured multiple times (e.g. by setting the device
address), which results in a host of errors in the logs:
debugfs: File 'features' in directory 'hci0' already present!
debugfs: File 'manufacturer' in directory 'hci0' already present!
debugfs: File 'hci_version' in directory 'hci0' already present!
...
debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present!
The Qualcomm driver suffers from a related problem for controllers with
non-persistent setup.
Johan
Johan Hovold (2):
Bluetooth: fix debugfs registration
Bluetooth: hci_qca: fix debugfs registration
drivers/bluetooth/hci_qca.c | 6 +++++-
include/net/bluetooth/hci.h | 1 +
net/bluetooth/hci_sync.c | 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
--
2.39.2
next reply other threads:[~2023-04-24 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:48 Johan Hovold [this message]
2023-04-24 12:48 ` [PATCH 1/2] Bluetooth: fix debugfs registration Johan Hovold
2023-05-02 23:37 ` Luiz Augusto von Dentz
2023-05-03 7:04 ` Johan Hovold
2023-05-03 17:34 ` Luiz Augusto von Dentz
2023-05-04 8:26 ` Johan Hovold
2023-04-24 12:48 ` [PATCH 2/2] Bluetooth: hci_qca: " Johan Hovold
2023-05-30 14:22 ` [PATCH 0/2] Bluetooth: " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424124852.12625-1-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).