Re: [PATCH 1/2] wifi: mt7601u: delete dead code checking debugfs returns

Re: [PATCH 1/2] wifi: mt7601u: delete dead code checking debugfs returns

[Jakub Kicinski]

On Tue, 25 Apr 2023 11:15:04 +0800 (CST) ktestrobot@126.com wrote:
> Hi, Wang Jikai
> This email is automatically replied by KTestRobot(Beta). Please do not reply to this email.
> If you have any questions or suggestions about KTestRobot, please contact ZhongYong <U201911841@hust.edu.cn>

What is this? Please don't spam people with some random bot output.

Re: [PATCH 1/2] wifi: mt7601u: delete dead code checking debugfs returns

[钟勇]

On 2023-04-25 22:07:03, Jakub Kicinski wrote:
> On Tue, 25 Apr 2023 11:15:04 +0800 (CST) ktestrobot@126.com wrote:
> > Hi, Wang Jikai
> > This email is automatically replied by KTestRobot(Beta). Please do not reply to this email.
> > If you have any questions or suggestions about KTestRobot, please contact ZhongYong <U201911841@hust.edu.cn>
> 
> What is this? Please don't spam people with some random bot output.

We are sorry about this situation. Our robot development introduced a 
logic error in checking patches, i.e., it does not check if this patch 
is sent out to LKML.

Please ignore this robot message. Really sorry about this alarm.

ZhongYong

[PATCH 1/2] wifi: mt7601u: delete dead code checking debugfs returns

[Wang Jikai]

Smatch reports that:
drivers/net/wireless/mediatek/mt7601u/debugfs.c:130
mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid".

Debugfs code is not supposed to need error checking so instead of
changing this to if (IS_ERR()) the correct thing is to just delete
the dead code.

Fixes: c869f77d6abb ("add mt7601u driver")
Signed-off-by: Wang Jikai <wangjikai@hust.edu.cn>
---
The issue is found by static analysis and remains untested.
---
 drivers/net/wireless/mediatek/mt7601u/debugfs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
index 230b0e1061a7..dbddf256921b 100644
--- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
@@ -127,8 +127,6 @@ void mt7601u_init_debugfs(struct mt7601u_dev *dev)
 	struct dentry *dir;
 
 	dir = debugfs_create_dir("mt7601u", dev->hw->wiphy->debugfsdir);
-	if (!dir)
-		return;
 
 	debugfs_create_u8("temperature", 0400, dir, &dev->raw_temp);
 	debugfs_create_u32("temp_mode", 0400, dir, &dev->temp_mode);
-- 
2.34.1

Re: [PATCH 1/2] wifi: mt7601u: delete dead code checking debugfs returns

[Jakub Kicinski]

On Thu, 20 Apr 2023 13:08:14 +0000 Wang Jikai wrote:
> Smatch reports that:
> drivers/net/wireless/mediatek/mt7601u/debugfs.c:130
> mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid".
> 
> Debugfs code is not supposed to need error checking so instead of
> changing this to if (IS_ERR()) the correct thing is to just delete
> the dead code.
> 
> Fixes: c869f77d6abb ("add mt7601u driver")

Don't add a Fixes tag on this cleanup.
one - dead code is not a bug
two - the semantics have changed since the driver was added
      so it's certainly not the right Fixes tag