[PATCH] net/ncsi: clear Tx enable mode when handling a Config required AEN

[PATCH] net/ncsi: clear Tx enable mode when handling a Config required AEN

[cchoux]

Clear the channel Tx enable flag before reconfiguring the channel
when handling a Configuration Required AEN. To avoid misjudging that
the channel Tx has been enabled, which results in the Enable Channel
Network Tx command not being sent during channel reconfiguration.

Signed-off-by: cchoux <chou.cosmo@gmail.com>
---
 net/ncsi/ncsi-aen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
index b635c194f0a8..62fb1031763d 100644
--- a/net/ncsi/ncsi-aen.c
+++ b/net/ncsi/ncsi-aen.c
@@ -165,6 +165,7 @@ static int ncsi_aen_handler_cr(struct ncsi_dev_priv *ndp,
 	nc->state = NCSI_CHANNEL_INACTIVE;
 	list_add_tail_rcu(&nc->link, &ndp->channel_queue);
 	spin_unlock_irqrestore(&ndp->lock, flags);
+	nc->modes[NCSI_MODE_TX_ENABLE].enable = 0;
 
 	return ncsi_process_next_channel(ndp);
 }
-- 
2.34.1

Re: [PATCH] net/ncsi: clear Tx enable mode when handling a Config required AEN

[Jakub Kicinski]

On Tue, 25 Apr 2023 21:30:14 +0800 cchoux wrote:
> Clear the channel Tx enable flag before reconfiguring the channel
> when handling a Configuration Required AEN. To avoid misjudging that
> the channel Tx has been enabled, which results in the Enable Channel
> Network Tx command not being sent during channel reconfiguration.
> 
> Signed-off-by: cchoux <chou.cosmo@gmail.com>

Please add a Fixes tag pointing to the commit which introduced 
the problem.

Please use your legal name like you would for signing a legal document
(all UTF-8 characters are allowed).

-- 
pw-bot: cr

[PATCH v2] net/ncsi: clear Tx enable mode when handling a Config required AEN

[Cosmo Chou]

ncsi_channel_is_tx() determines whether a given channel should be
used for Tx or not. However, when reconfiguring the channel by
handling a Configuration Required AEN, there is a misjudgment that
the channel Tx has already been enabled, which results in the Enable
Channel Network Tx command not being sent.

Clear the channel Tx enable flag before reconfiguring the channel to
avoid the misjudgment.

Fixes: 8d951a75d022 ("net/ncsi: Configure multi-package, multi-channel modes with failover")
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
 net/ncsi/ncsi-aen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
index b635c194f0a8..62fb1031763d 100644
--- a/net/ncsi/ncsi-aen.c
+++ b/net/ncsi/ncsi-aen.c
@@ -165,6 +165,7 @@ static int ncsi_aen_handler_cr(struct ncsi_dev_priv *ndp,
 	nc->state = NCSI_CHANNEL_INACTIVE;
 	list_add_tail_rcu(&nc->link, &ndp->channel_queue);
 	spin_unlock_irqrestore(&ndp->lock, flags);
+	nc->modes[NCSI_MODE_TX_ENABLE].enable = 0;
 
 	return ncsi_process_next_channel(ndp);
 }
-- 
2.34.1

Re: [PATCH v2] net/ncsi: clear Tx enable mode when handling a Config required AEN

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 26 Apr 2023 16:13:50 +0800 you wrote:
> ncsi_channel_is_tx() determines whether a given channel should be
> used for Tx or not. However, when reconfiguring the channel by
> handling a Configuration Required AEN, there is a misjudgment that
> the channel Tx has already been enabled, which results in the Enable
> Channel Network Tx command not being sent.
> 
> Clear the channel Tx enable flag before reconfiguring the channel to
> avoid the misjudgment.
> 
> [...]

Here is the summary with links:
  - [v2] net/ncsi: clear Tx enable mode when handling a Config required AEN
    https://git.kernel.org/netdev/net/c/6f75cd166a5a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html