From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>
Subject: Re: [EXT] Re: [net PATCH 5/9] octeontx2-pf: mcs: Fix NULL pointer dereferences
Date: Tue, 25 Apr 2023 08:51:40 -0700 [thread overview]
Message-ID: <20230425085140.000bbcc1@kernel.org> (raw)
In-Reply-To: <CO1PR18MB4666A3A7B44081290B37E375A1679@CO1PR18MB4666.namprd18.prod.outlook.com>
On Mon, 24 Apr 2023 10:29:02 +0000 Subbaraya Sundeep Bhatta wrote:
> >How did you get call to .mdo_del_secy if you didn't add any secy?
> >
> >Thanks
> >
> It is because of the order of teardown in otx2_remove:
> cn10k_mcs_free(pf);
> unregister_netdev(netdev);
>
> cn10k_mcs_free free the resources and makes cfg as NULL.
> Later unregister_netdev calls mdo_del_secy and finds cfg as NULL.
> Thanks for the review I will change the order and submit next version.
Leon, ack? Looks like the patches got "changes requested" but I see
no other complaint.
next prev parent reply other threads:[~2023-04-25 15:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 9:54 [net PATCH 0/9] Macsec fixes for CN10KB Geetha sowjanya
2023-04-23 9:54 ` [net PATCH 1/9] octeonxt2-af: mcs: Fix per port bypass config Geetha sowjanya
2023-04-23 16:48 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 2/9] octeontx2-af: mcs: Write TCAM_DATA and TCAM_MASK registers at once Geetha sowjanya
2023-04-23 16:47 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 3/9] octeontx2-af: mcs: Config parser to skip 8B header Geetha sowjanya
2023-04-23 16:48 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 4/9] octeontx2-af: mcs: Fix MCS block interrupt Geetha sowjanya
2023-04-23 16:49 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 5/9] octeontx2-pf: mcs: Fix NULL pointer dereferences Geetha sowjanya
2023-04-23 16:51 ` Leon Romanovsky
2023-04-24 10:29 ` [EXT] " Subbaraya Sundeep Bhatta
2023-04-25 15:51 ` Jakub Kicinski [this message]
2023-04-26 6:16 ` Leon Romanovsky
2023-04-26 6:52 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 6/9] octeontx2-pf: mcs: Match macsec ethertype along with DMAC Geetha sowjanya
2023-04-23 16:52 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 7/9] octeontx2-pf: mcs: Clear stats before freeing resource Geetha sowjanya
2023-04-23 16:54 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 8/9] octeontx2-pf: mcs: Fix shared counters logic Geetha sowjanya
2023-04-23 16:54 ` Leon Romanovsky
2023-04-23 9:54 ` [net PATCH 9/9] octeontx2-pf: mcs: Do not reset PN while updating secy Geetha sowjanya
2023-04-23 16:56 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425085140.000bbcc1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).