From: Andi Shyti <andi.shyti@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, linux@armlinux.org.uk,
jarkko.nikula@linux.intel.com, olteanv@gmail.com,
andriy.shevchenko@linux.intel.com, hkallweit1@gmail.com,
linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next v4 3/8] net: txgbe: Register I2C platform device
Date: Tue, 25 Apr 2023 17:06:19 +0200 [thread overview]
Message-ID: <20230425150619.cj7ed2efnbvjk5mm@intel.intel> (raw)
In-Reply-To: <20230422045621.360918-4-jiawenwu@trustnetic.com>
Hi Jiawen,
[...]
> + ret = txgbe_i2c_register(txgbe);
> + if (ret) {
> + wx_err(txgbe->wx, "failed to init i2c interface: %d\n", ret);
> + goto err_unregister_swnode;
> + }
> +
> return 0;
> +
> +err_unregister_swnode:
> + software_node_unregister_node_group(txgbe->nodes.group);
> +
> + return ret;
no need for the goto here... in my opinion it's easier if you put
software_node_unregister_node_group() under the if and return
ret.
Andi
next prev parent reply other threads:[~2023-04-25 15:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 4:56 [PATCH net-next v4 0/8] TXGBE PHYLINK support Jiawen Wu
2023-04-22 4:56 ` [PATCH net-next v4 1/8] net: txgbe: Add software nodes to support phylink Jiawen Wu
2023-04-23 19:47 ` Simon Horman
2023-04-22 4:56 ` [PATCH net-next v4 2/8] i2c: designware: Add driver support for Wangxun 10Gb NIC Jiawen Wu
2023-04-22 16:25 ` Andy Shevchenko
2023-04-23 2:31 ` Jiawen Wu
2023-04-24 13:28 ` 'Andy Shevchenko'
2023-04-24 2:39 ` Jiawen Wu
2023-04-25 14:08 ` Andi Shyti
2023-05-01 18:28 ` Andy Shevchenko
2023-04-22 4:56 ` [PATCH net-next v4 3/8] net: txgbe: Register I2C platform device Jiawen Wu
2023-04-25 15:06 ` Andi Shyti [this message]
2023-04-25 15:16 ` Andi Shyti
2023-04-22 4:56 ` [PATCH net-next v4 4/8] net: txgbe: Add SFP module identify Jiawen Wu
2023-04-22 4:56 ` [PATCH net-next v4 5/8] net: txgbe: Support GPIO to SFP socket Jiawen Wu
2023-04-22 4:56 ` [PATCH net-next v4 6/8] net: pcs: Add 10GBASE-R mode for Synopsys Designware XPCS Jiawen Wu
2023-05-02 8:01 ` Russell King (Oracle)
2023-04-22 4:56 ` [PATCH net-next v4 7/8] net: txgbe: Implement phylink pcs Jiawen Wu
2023-04-22 4:56 ` [PATCH net-next v4 8/8] net: txgbe: Support phylink MAC layer Jiawen Wu
2023-04-23 19:57 ` Simon Horman
2023-04-24 1:49 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425150619.cj7ed2efnbvjk5mm@intel.intel \
--to=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).