From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9B5C6FD18 for ; Tue, 25 Apr 2023 17:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234889AbjDYRE1 (ORCPT ); Tue, 25 Apr 2023 13:04:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234700AbjDYRE0 (ORCPT ); Tue, 25 Apr 2023 13:04:26 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FBC35BAC for ; Tue, 25 Apr 2023 10:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682442265; x=1713978265; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PNZj+ThPAJxMyqk9Vt8Voy7NPKQwcD+YsF7Lamil2+4=; b=IojF2s9YGUHiVvmtK02P5H5fdA+cENs/jP+NQpPWEmpJI2/s7Hu4RbMd OPNB1XEoHWvp31z3kOQHIp1Kbeoz0smFfSrYJBmi7ws3dR1TRRBtQovf3 pqzvzs1/XotKEH7d+RjR2p0sIWMibKJgXB+kquc8M58EBBWboeeTCOMo/ yGrUJteOVhHktasJlWhW8+ndjst+K2OWDLoxjbjkjPLyk7KY5RMMpALlM Z1dhLfNEPTKQrt5eOg7/I7fqqdwemWprMd58APqWT2NfmYrwbhvflBPbP RaHEOPWXmNL+l1suTTCnoQQfKAZ4vIzLHQ6Xw+dMMS70qwvafWR2JRI0o A==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="326436772" X-IronPort-AV: E=Sophos;i="5.99,226,1677571200"; d="scan'208";a="326436772" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 10:04:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="724085191" X-IronPort-AV: E=Sophos;i="5.99,226,1677571200"; d="scan'208";a="724085191" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orsmga008.jf.intel.com with ESMTP; 25 Apr 2023 10:04:23 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org Cc: Ahmed Zaki , anthony.l.nguyen@intel.com, Alexander Lobakin , Rafal Romanowski Subject: [PATCH net 1/3] ice: Fix stats after PF reset Date: Tue, 25 Apr 2023 10:01:25 -0700 Message-Id: <20230425170127.2522312-2-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230425170127.2522312-1-anthony.l.nguyen@intel.com> References: <20230425170127.2522312-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ahmed Zaki After a core PF reset, the VFs were showing wrong Rx/Tx stats. This is a regression in commit 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") caused by missing to set "stat_offsets_loaded = false" in the ice_vsi_rebuild() path. Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") Signed-off-by: Ahmed Zaki Reviewed-by: Alexander Lobakin Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index 450317dfcca7..11ae0e41f518 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -2745,6 +2745,8 @@ ice_vsi_cfg_def(struct ice_vsi *vsi, struct ice_vsi_cfg_params *params) goto unroll_vector_base; ice_vsi_map_rings_to_vectors(vsi); + vsi->stat_offsets_loaded = false; + if (ice_is_xdp_ena_vsi(vsi)) { ret = ice_vsi_determine_xdp_res(vsi); if (ret) @@ -2793,6 +2795,9 @@ ice_vsi_cfg_def(struct ice_vsi *vsi, struct ice_vsi_cfg_params *params) ret = ice_vsi_alloc_ring_stats(vsi); if (ret) goto unroll_vector_base; + + vsi->stat_offsets_loaded = false; + /* Do not exit if configuring RSS had an issue, at least * receive traffic on first queue. Hence no need to capture * return value -- 2.38.1