From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C136C7618E for ; Wed, 26 Apr 2023 06:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239572AbjDZGv3 (ORCPT ); Wed, 26 Apr 2023 02:51:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239514AbjDZGv1 (ORCPT ); Wed, 26 Apr 2023 02:51:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9D3B10EB; Tue, 25 Apr 2023 23:51:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 886C06334F; Wed, 26 Apr 2023 06:51:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB8FC433EF; Wed, 26 Apr 2023 06:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682491885; bh=aNiVjLYtZfJBHJpmXwfeVLdQ2tFgLGhNkuLVqZMq3RI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+cD+aaVcChHw+C8oPLdC0hqhWGu0NPMyKHXTH+56xWtGkUbZP3J9m+t0pdUhcz98 K1cYZ5GT4KeLe9/n1o8WYq1vqoFqn8wECPJI8mEXXHkBgBFFnJ8z4gc0a/AInZAIS3 BQOee2jywgcMmMHu7BmNdFlYJhMe8U5JyynnjZlWx+MgxqSm/gk/gRzHwQRpF2sWgy V7e/Ulw96UaMBtrUQk/HwIvBU+yZecnSoAS0RzLxIwad2bmYftoKVfLah/6gKX81dj kVhVUccbF0wdAXGx3Sx7Y0FP2jAGF23HTMSqcR5ojD0C5Uiz2XxHy0cvugaliyteHv igdeX+KWyZuYw== Date: Wed, 26 Apr 2023 09:51:21 +0300 From: Leon Romanovsky To: Geetha sowjanya Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com, sgoutham@marvell.com, sbhatta@marvell.com, hkelam@marvell.com Subject: Re: [net PATCH v2 5/9] octeontx2-pf: mcs: Fix NULL pointer dereferences Message-ID: <20230426065121.GI27649@unreal> References: <20230426062528.20575-1-gakula@marvell.com> <20230426062528.20575-6-gakula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230426062528.20575-6-gakula@marvell.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 26, 2023 at 11:55:24AM +0530, Geetha sowjanya wrote: > From: Subbaraya Sundeep > > When system is rebooted after creating macsec interface > below NULL pointer dereference crashes occurred. This > patch fixes those crashes by using correct order of teardown > > [ 3324.406942] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > [ 3324.415726] Mem abort info: > [ 3324.418510] ESR = 0x96000006 > [ 3324.421557] EC = 0x25: DABT (current EL), IL = 32 bits > [ 3324.426865] SET = 0, FnV = 0 > [ 3324.429913] EA = 0, S1PTW = 0 > [ 3324.433047] Data abort info: > [ 3324.435921] ISV = 0, ISS = 0x00000006 > [ 3324.439748] CM = 0, WnR = 0 > .... > [ 3324.575915] Call trace: > [ 3324.578353] cn10k_mdo_del_secy+0x24/0x180 > [ 3324.582440] macsec_common_dellink+0xec/0x120 > [ 3324.586788] macsec_notify+0x17c/0x1c0 > [ 3324.590529] raw_notifier_call_chain+0x50/0x70 > [ 3324.594965] call_netdevice_notifiers_info+0x34/0x7c > [ 3324.599921] rollback_registered_many+0x354/0x5bc > [ 3324.604616] unregister_netdevice_queue+0x88/0x10c > [ 3324.609399] unregister_netdev+0x20/0x30 > [ 3324.613313] otx2_remove+0x8c/0x310 > [ 3324.616794] pci_device_shutdown+0x30/0x70 > [ 3324.620882] device_shutdown+0x11c/0x204 > > [ 966.664930] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > [ 966.673712] Mem abort info: > [ 966.676497] ESR = 0x96000006 > [ 966.679543] EC = 0x25: DABT (current EL), IL = 32 bits > [ 966.684848] SET = 0, FnV = 0 > [ 966.687895] EA = 0, S1PTW = 0 > [ 966.691028] Data abort info: > [ 966.693900] ISV = 0, ISS = 0x00000006 > [ 966.697729] CM = 0, WnR = 0 > [ 966.833467] Call trace: > [ 966.835904] cn10k_mdo_stop+0x20/0xa0 > [ 966.839557] macsec_dev_stop+0xe8/0x11c > [ 966.843384] __dev_close_many+0xbc/0x140 > [ 966.847298] dev_close_many+0x84/0x120 > [ 966.851039] rollback_registered_many+0x114/0x5bc > [ 966.855735] unregister_netdevice_many.part.0+0x14/0xa0 > [ 966.860952] unregister_netdevice_many+0x18/0x24 > [ 966.865560] macsec_notify+0x1ac/0x1c0 > [ 966.869303] raw_notifier_call_chain+0x50/0x70 > [ 966.873738] call_netdevice_notifiers_info+0x34/0x7c > [ 966.878694] rollback_registered_many+0x354/0x5bc > [ 966.883390] unregister_netdevice_queue+0x88/0x10c > [ 966.888173] unregister_netdev+0x20/0x30 > [ 966.892090] otx2_remove+0x8c/0x310 > [ 966.895571] pci_device_shutdown+0x30/0x70 > [ 966.899660] device_shutdown+0x11c/0x204 > [ 966.903574] __do_sys_reboot+0x208/0x290 > [ 966.907487] __arm64_sys_reboot+0x20/0x30 > [ 966.911489] el0_svc_handler+0x80/0x1c0 > [ 966.915316] el0_svc+0x8/0x180 > [ 966.918362] Code: f9400000 f9400a64 91220014 f94b3403 (f9400060) > [ 966.924448] ---[ end trace 341778e799c3d8d7 ]--- > > Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading") > Signed-off-by: Subbaraya Sundeep > Signed-off-by: Sunil Goutham > Signed-off-by: Geetha sowjanya > --- > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky