From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A295C7618E for ; Wed, 26 Apr 2023 07:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240083AbjDZHqZ (ORCPT ); Wed, 26 Apr 2023 03:46:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240041AbjDZHpz (ORCPT ); Wed, 26 Apr 2023 03:45:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F8C46A2 for ; Wed, 26 Apr 2023 00:45:07 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prZpl-0001uX-Ky; Wed, 26 Apr 2023 09:45:01 +0200 Received: from pza by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1prZpd-0001gO-Ow; Wed, 26 Apr 2023 09:44:53 +0200 Date: Wed, 26 Apr 2023 09:44:53 +0200 From: Philipp Zabel To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sean Wang , Landen Chao , DENG Qingfang , Russell King , =?utf-8?B?QXLEsW7DpyDDnG5hbA==?= , Sam Shih , Lorenzo Bianconi , John Crispin , Felix Fietkau Subject: Re: [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for MT7988 built-in switch Message-ID: <20230426074453.GD4724@pengutronix.de> References: <20230425155137.GA19130@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: pza@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Daniel, On Tue, Apr 25, 2023 at 05:11:36PM +0100, Daniel Golle wrote: > On Tue, Apr 25, 2023 at 05:51:37PM +0200, Philipp Zabel wrote: [...] > > Please use devm_reset_control_get_exclusive() directly. > > > > > + if (IS_ERR(priv->rstc)) { > > > + dev_err(&pdev->dev, "Couldn't get our reset line\n"); > > > + return PTR_ERR(priv->rstc); > > > > Not sure if this can actually happen, but there is no need to warn on > > -EPROBE_DEFER. You could use return dev_err_probe(...) here. > > Thank you for your comments. The series has already been picked to > net-next. Unless you want to send the suggested changes yourself, I will > prepare another series with your suggestions, and also apply them to > mt7530-mdio.c. That would be great, thank you. regards Philipp