From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26871C77B73 for ; Thu, 27 Apr 2023 17:03:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244060AbjD0RDS (ORCPT ); Thu, 27 Apr 2023 13:03:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244044AbjD0RDR (ORCPT ); Thu, 27 Apr 2023 13:03:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 185962735; Thu, 27 Apr 2023 10:03:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A868F60FAD; Thu, 27 Apr 2023 17:03:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82C70C433D2; Thu, 27 Apr 2023 17:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682614986; bh=5keD3A76mAYABXbJJi98ucTVufEPv+s0TFrG0i+pRO0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ys6Ej7qLO0lfHZkCvZjvRuXz1+qpgxQwcZCsCMr4NAMLepb9DwezpDrd4xL0PhgrX fdNijyCeWH8T73dBFzgCAmkcDfssOF8LS3FhWEaOSP4O47UKZKzNUtD6mlvmE//mWu 6vwQyWKGoC/RAXCyuVsKDcU0CTw9YuYF1fRFIS6Sma4waRA/Tcltqd9RCtBplwJnL5 /q6TlCq71z8hM4KNbHLCWiNS/dBipaYBLyUNd7UVOTqbkqtz1koA0A3i+Q5NIrwj4U z1hP9ngzIiFEc3JZ3akVYjAnVDoz6iEIGJQaCIyo6SaA06+ERXQIMLMt78c4wuydbt 2hkcOMuHbcc6w== Date: Thu, 27 Apr 2023 10:03:04 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "zbr@ioremap.net" , "brauner@kernel.org" , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Message-ID: <20230427100304.1807bcde@kernel.org> In-Reply-To: <57A9B006-C6FC-463D-BA05-D927126899BB@oracle.com> References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com> <20230331235528.1106675-2-anjali.k.kulkarni@oracle.com> <20230331210920.399e3483@kernel.org> <88FD5EFE-6946-42C4-881B-329C3FE01D26@oracle.com> <20230401121212.454abf11@kernel.org> <4E631493-D61F-4778-A392-3399DF400A9D@oracle.com> <20230403135008.7f492aeb@kernel.org> <57A9B006-C6FC-463D-BA05-D927126899BB@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 26 Apr 2023 23:58:55 +0000 Anjali Kulkarni wrote: > Jakub, could you please look into reviewing patches 3,4 & 5 as well? > Patch 4 is just test code. Patch 3 is fixing bug fixes in current > code so should be good to have - also it is not too connector > specific. I can explain patch 5 in more detail if needed. I don't have sufficient knowledge to review that code, sorry :(