From: Antoine Tenart <atenart@kernel.org>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com
Cc: Antoine Tenart <atenart@kernel.org>, netdev@vger.kernel.org
Subject: [PATCH net-next 0/4] net: tcp: make txhash use consistent for IPv4
Date: Thu, 27 Apr 2023 15:45:23 +0200 [thread overview]
Message-ID: <20230427134527.18127-1-atenart@kernel.org> (raw)
Hello,
Series is divided in two parts. First two commits make the txhash (used
for the skb hash in TCP) to be consistent for all IPv4/TCP packets (IPv6
doesn't have the same issue). Last two commits improve doc/comment
hash-related parts.
One example is when using OvS with dp_hash, which uses skb->hash, to
select a path. We'd like packets from the same flow to be consistent, as
well as the hash being stable over time when using net.core.txrehash=0.
Same applies for kernel ECMP which also can use skb->hash.
IMHO the series makes sense in net-next, but we could argue (some)
commits be seen as fixes and I can resend if necessary.
Thanks!
Antoine
Antoine Tenart (4):
net: tcp: make the txhash available in TIME_WAIT sockets for IPv4 too
net: ipv4: use consistent txhash in TIME_WAIT and SYN_RECV
Documentation: net: net.core.txrehash is not specific to listening
sockets
net: skbuff: fix l4_hash comment
Documentation/admin-guide/sysctl/net.rst | 4 ++--
include/linux/skbuff.h | 4 ++--
include/net/ip.h | 2 +-
net/ipv4/ip_output.c | 4 +++-
net/ipv4/tcp_ipv4.c | 14 +++++++++-----
net/ipv4/tcp_minisocks.c | 2 +-
6 files changed, 18 insertions(+), 12 deletions(-)
--
2.40.0
next reply other threads:[~2023-04-27 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 13:45 Antoine Tenart [this message]
2023-04-27 13:45 ` [PATCH net-next 1/4] net: tcp: make the txhash available in TIME_WAIT sockets for IPv4 too Antoine Tenart
2023-04-27 13:45 ` [PATCH net-next 2/4] net: ipv4: use consistent txhash in TIME_WAIT and SYN_RECV Antoine Tenart
2023-04-27 13:45 ` [PATCH net-next 3/4] Documentation: net: net.core.txrehash is not specific to listening sockets Antoine Tenart
2023-04-27 13:45 ` [PATCH net-next 4/4] net: skbuff: fix l4_hash comment Antoine Tenart
2023-04-27 15:15 ` [PATCH net-next 0/4] net: tcp: make txhash use consistent for IPv4 Eric Dumazet
2023-04-27 15:44 ` Antoine Tenart
-- strict thread matches above, loose matches on Subject: below --
2023-05-11 9:34 Antoine Tenart
2023-05-11 10:24 ` Eric Dumazet
2023-05-11 11:55 ` Antoine Tenart
2023-05-11 11:59 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427134527.18127-1-atenart@kernel.org \
--to=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).