Re: [PATCH net-next RFC v4 2/5] net: Expose available time stamping layers to user space.

Michael Walle
2023-04-12T11:13:32Z

Am 2023-04-12 13:08, schrieb Vladimir Oltean:
> On Wed, Apr 12, 2023 at 12:50:34PM +0200, Michael Walle wrote:
>> >> +/* Hardware layer of the SO_TIMESTAMPING provider */
>> >> +enum timestamping_layer {
>> >> + SOF_MAC_TIMESTAMPING =3D (1<<0),
>> >> + SOF_PHY_TIMESTAMPING =3D (1<<1),
>> >
>> > What does SOF_ stand for?
>>
>> I'd guess start of frame. The timestamp will be taken at the
>> beginning of the frame.
>
> I would suggest (with all due respect) that it was an inapt adaptation
> of the Socket Option Flags that can be seen in
> Documentation/networking/timestamping.rst.

Agreed. Noticing the other SOF_TIMESTAMPING_* names, your
suggestion makes way more sense. Sorry for the noise.

-michael