Re: [PATCH net-next RFC v4 3/5] dt-bindings: net: phy: add timestamp preferred choice property

Köry Maincent
2023-04-12T13:45:13Z

On Wed, 12 Apr 2023 16:14:21 +0300
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:

> > + preferred-timestamp:
> > + enum:
> > + - phy
> > + - mac
> > + description:
> > + Specifies the preferred hardware timestamp layer.
> > +
> > pses:
> > $ref: /schemas/types.yaml#/definitions/phandle-array
> > maxItems: 1
> > --
> > 2.25.1
> >
>
> Do we need this device tree functionality?

I would say so. Expected as I wrote the patch. ;)

My point was that the new behavior to MAC as default timestamping does not fit
all the case, especially when a board is designed with PHY like the TI PHYTER
which is a far better timestamping choice (according to Richard). The user
doesn't need to know this, he wants to have the better time stamp selected by
default without any investigation. That's why having devicetree property for
that could be useful.