From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH v2 iproute2-next 09/10] tc/mqprio: add support for preemptible traffic classes
Date: Sun, 30 Apr 2023 04:33:14 +0300 [thread overview]
Message-ID: <20230430013314.saansheqqfn2j7wl@skbuf> (raw)
In-Reply-To: <20230429174255.564a9401@hermes.local>
On Sat, Apr 29, 2023 at 05:42:55PM -0700, Stephen Hemminger wrote:
> On Tue, 18 Apr 2023 14:39:52 +0300
> Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> > + tc = rta_getattr_u32(tb[TCA_MQPRIO_TC_ENTRY_INDEX]);
> > + /* Prevent array out of bounds access */
> > + if (tc >= TC_QOPT_MAX_QUEUE) {
> > + fprintf(stderr, "Unexpected tc entry index %d\n", tc);
> > + return;
> > + }
>
> This creates a ABI dependency, what if kernel config changes?
>
If TC_QOPT_MAX_QUEUE changes its value, struct tc_mqprio_qopt changes
its binary layout in an incompatible way.
next prev parent reply other threads:[~2023-04-30 1:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:39 [PATCH v2 iproute2-next 00/10] Add tc-mqprio and tc-taprio support for preemptible traffic classes Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 01/10] tc/taprio: add max-sdu to the man page SYNOPSIS section Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 02/10] tc/taprio: add a size table to the examples from the man page Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 03/10] tc/mqprio: fix stray ] in man page synopsis Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 04/10] tc/mqprio: use words in man page to express min_rate/max_rate dependency on bw_rlimit Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 05/10] tc/mqprio: break up synopsis into multiple lines Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 06/10] tc/taprio: break up help text " Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 07/10] Update kernel headers Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 08/10] utils: add max() definition Vladimir Oltean
2023-04-18 11:39 ` [PATCH v2 iproute2-next 09/10] tc/mqprio: add support for preemptible traffic classes Vladimir Oltean
2023-04-30 0:42 ` Stephen Hemminger
2023-04-30 1:33 ` Vladimir Oltean [this message]
2023-04-18 11:39 ` [PATCH v2 iproute2-next 10/10] tc/taprio: " Vladimir Oltean
2023-04-22 16:14 ` [PATCH v2 iproute2-next 00/10] Add tc-mqprio and tc-taprio " David Ahern
2023-04-22 16:59 ` Vladimir Oltean
2023-04-25 1:47 ` David Ahern
2023-04-25 12:55 ` Vladimir Oltean
2023-04-26 0:42 ` David Ahern
2023-04-24 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230430013314.saansheqqfn2j7wl@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).