From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5BAC77B61 for ; Mon, 1 May 2023 14:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232303AbjEAOS6 (ORCPT ); Mon, 1 May 2023 10:18:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbjEAOS4 (ORCPT ); Mon, 1 May 2023 10:18:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C5BB3 for ; Mon, 1 May 2023 07:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682950691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZbS5IjUaNlPU8hbwLWUCcqwd+h51QQNEXep9a6KbrKM=; b=LmMxM8OK81GuLOtwSKFwfj7hqcEDyDWOXOYiMDOsjFeAMHY2IZpg6EwLR60gPDlvntEFvH UUxcAXxfKvhUknVXrrw8T3w9aXrOpUUdBOJGPdtes38jRmEEcSFIVe2urKYWcChNTz6uOK doZcMqMY914rLLF9B5gdxN1/sFQMiZY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-RjZTNIvsNWCZ1hadIyFBsg-1; Mon, 01 May 2023 10:14:26 -0400 X-MC-Unique: RjZTNIvsNWCZ1hadIyFBsg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f336ecf58cso5135405e9.1 for ; Mon, 01 May 2023 07:14:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682950444; x=1685542444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZbS5IjUaNlPU8hbwLWUCcqwd+h51QQNEXep9a6KbrKM=; b=b+IkrHJsIQAt0JapUX0IHrg/r9r1F6kBHSUv+l5bwYY8keJW1/6cMdmNgchr3XL91X Pn0Oe5vuvSX/BSEWw39APnzObed6nLMxNavQiHeK14fKzSwyILGk4GsGiQTA44uYc6qk TasORdF+uqiTzdA5DGfJBmW8XqovDk3+SnzAW555F5/QvSmJDyIm+BQqMb0J4WuIkyRO 6KKGZmTASdEH6r0S2UV1ce1kpA9qJ8z/btiWo679WtQ0ECFTYHAt2xLiYOxkSrDUdkDx 5fk46EpcQe+FuXbtbvkLaiTXPLrC28usKshCxk15Rw3FaN9XCJoBzW+svNG89eNQ/EOl am5A== X-Gm-Message-State: AC+VfDwCeahD1YJLKGM4Olx7JCShWMty7DtXhh3LgEYOPtv7uB8/6B3B 3bB2E2gKuFnBQw8phFfP64xlniXsB44nhrOugBIo1aHHDj191eoHZ6Vv4qgODIBi/wIstwNzzXz W7Z3joFwd+Wt7hmQz X-Received: by 2002:a1c:4b06:0:b0:3f0:3d47:2cc5 with SMTP id y6-20020a1c4b06000000b003f03d472cc5mr10326841wma.10.1682950443988; Mon, 01 May 2023 07:14:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5uwbn+68k6dEwgamd9RB+Cf3SAOrfWXIAOfHT0cY5NAJ1rKClQM9jVpxSANY9aJ1gTlwwrQA== X-Received: by 2002:a1c:4b06:0:b0:3f0:3d47:2cc5 with SMTP id y6-20020a1c4b06000000b003f03d472cc5mr10326826wma.10.1682950443676; Mon, 01 May 2023 07:14:03 -0700 (PDT) Received: from redhat.com ([31.210.184.46]) by smtp.gmail.com with ESMTPSA id f22-20020a1c6a16000000b003f17e79d74asm33036957wmc.7.2023.05.01.07.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 07:14:03 -0700 (PDT) Date: Mon, 1 May 2023 10:14:00 -0400 From: "Michael S. Tsirkin" To: Feng Liu Cc: Simon Horman , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Jason Wang , Xuan Zhuo , William Tu , Parav Pandit Subject: Re: [PATCH net v1 2/2] virtio_net: Close queue pairs using helper function Message-ID: <20230501101231-mutt-send-email-mst@kernel.org> References: <20230428224346.68211-1-feliu@nvidia.com> <9dba94bb-3e40-6809-3f5a-cbb0ae19c5b7@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9dba94bb-3e40-6809-3f5a-cbb0ae19c5b7@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 01, 2023 at 09:58:18AM -0400, Feng Liu wrote: > > > On 2023-05-01 a.m.8:44, Simon Horman wrote: > > External email: Use caution opening links or attachments > > > > > > On Fri, Apr 28, 2023 at 06:43:46PM -0400, Feng Liu wrote: > > > Use newly introduced helper function that exactly does the same of > > > closing the queue pairs. > > > > > > Signed-off-by: Feng Liu > > > Reviewed-by: William Tu > > > Reviewed-by: Parav Pandit > > > > I guess this was put in a separate patch to 1/2, as it's more > > net-next material, as opposed to 1/2 which seems to be net material. > > FWIIW, I'd lean to putting 1/2 in net. And holding this one for net-next. > > > > That aside, this looks good to me. > > > > Reviewed-by: Simon Horman > > Will do, thanks Simon Nah, I think you should just squash these two patches together. It's early in the merge window. -- MST