From: Jakub Kicinski <kuba@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: pull-request: wireless-next-2023-04-21
Date: Mon, 1 May 2023 15:08:03 -0700 [thread overview]
Message-ID: <20230501150803.6c4963ac@kernel.org> (raw)
In-Reply-To: <87cz3os2wr.fsf@kernel.org>
On Fri, 28 Apr 2023 13:43:16 +0300 Kalle Valo wrote:
> > I don't think it's that much extra work, the driver requires FW
> > according to modinfo, anyway, so /lib/firmware is already required.
> > And on smaller systems with few hundred MB of RAM it'd be nice to not
> > hold all the stuff in kernel memory, I'd think.
>
> Later in this thread Ping explained pretty well the challenges here,
> that sums exactly what I'm worried about.
>
> > We have a rule against putting FW as a static table in the driver
> > source, right? Or did we abandon that? Isn't this fundamentally similar?
>
> My understanding is that these are just initialisation values for
> hardware, not executable code. (Ping, please correct me if I
> misunderstood.) So that's why I thought these are ok to have in kernel.
> So I took practicality over elegance here.
Alright, I'll try to make someone else do this outside of wireless,
and come back with real life experience disproving the concerns :)
next prev parent reply other threads:[~2023-05-01 22:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 10:47 pull-request: wireless-next-2023-04-21 Kalle Valo
2023-04-21 14:39 ` Jakub Kicinski
2023-04-24 17:34 ` Kalle Valo
2023-04-25 20:52 ` Ryder Lee
2023-04-28 8:50 ` Kalle Valo
2023-04-21 14:54 ` Jakub Kicinski
2023-04-25 2:41 ` Ping-Ke Shih
2023-04-25 4:14 ` Gregg Wonderly
2023-04-25 4:42 ` Ping-Ke Shih
2023-04-25 5:38 ` Kalle Valo
2023-04-25 14:18 ` Jakub Kicinski
2023-04-25 17:08 ` Johannes Berg
2023-04-26 3:15 ` Ping-Ke Shih
2023-04-26 3:30 ` Ping-Ke Shih
2023-04-26 8:24 ` Johannes Berg
2023-04-27 0:38 ` Ping-Ke Shih
2023-04-28 10:37 ` Kalle Valo
2023-04-28 10:43 ` Kalle Valo
2023-05-01 22:08 ` Jakub Kicinski [this message]
2023-04-21 15:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501150803.6c4963ac@kernel.org \
--to=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).