From: Jakub Kicinski <kuba@kernel.org>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: Ivan Vecera <ivecera@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
Pedro Tammela <pctammela@mojatatu.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <jhs@mojatatu.com>,
<xiyou.wangcong@gmail.com>, <jiri@resnulli.us>,
<marcelo.leitner@gmail.com>, <paulb@nvidia.com>,
"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH net 2/2] net/sched: flower: fix error handler on replace
Date: Tue, 2 May 2023 19:44:52 -0700 [thread overview]
Message-ID: <20230502194452.23e99a2c@kernel.org> (raw)
In-Reply-To: <87354ks1ob.fsf@nvidia.com>
On Fri, 28 Apr 2023 14:03:19 +0300 Vlad Buslov wrote:
> Note that with these changes (both accepted patch and preceding diff)
> you are exposing filter to dapapath access (datapath looks up filter via
> hash table, not idr) with its handle set to 0 initially and then resent
> while already accessible. After taking a quick look at Paul's
> miss-to-action code it seems that handle value used by datapath is taken
> from struct tcf_exts_miss_cookie_node not from filter directly, so such
> approach likely doesn't break anything existing, but I might have missed
> something.
Did we deadlock in this discussion, or the issue was otherwise fixed?
next prev parent reply other threads:[~2023-05-03 2:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 12:14 [PATCH net 0/2] Fixes for miss to tc action series Vlad Buslov
2023-04-26 12:14 ` [PATCH net 1/2] net/sched: flower: fix filter idr initialization Vlad Buslov
2023-04-26 14:25 ` Simon Horman
2023-04-26 14:27 ` Pedro Tammela
2023-04-27 5:53 ` Paul Blakey
2023-04-26 12:14 ` [PATCH net 2/2] net/sched: flower: fix error handler on replace Vlad Buslov
2023-04-26 14:06 ` Pedro Tammela
2023-04-26 14:22 ` Pedro Tammela
2023-04-26 14:46 ` Vlad Buslov
2023-04-26 15:24 ` Pedro Tammela
2023-04-26 15:39 ` Ivan Vecera
2023-04-28 7:11 ` Simon Horman
2023-04-28 8:20 ` Ivan Vecera
2023-04-28 11:03 ` Vlad Buslov
2023-05-03 2:44 ` Jakub Kicinski [this message]
2023-05-04 13:40 ` Vlad Buslov
2023-05-04 14:24 ` Paolo Abeni
2023-05-04 18:32 ` Vlad Buslov
2023-05-05 13:25 ` Simon Horman
2023-04-27 5:52 ` Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502194452.23e99a2c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=pctammela@mojatatu.com \
--cc=simon.horman@corigine.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).