From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Ding Hui <dinghui@sangfor.com.cn>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, keescook@chromium.org,
grzegorzx.szczurek@intel.com, mateusz.palczewski@intel.com,
mitch.a.williams@intel.com, gregory.v.rose@intel.com,
jeffrey.t.kirsher@intel.com, michal.kubiak@intel.com,
simon.horman@corigine.com, madhu.chittim@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, pengdonglin@sangfor.com.cn,
huangcun@sangfor.com.cn
Subject: Re: [PATCH net v4 2/2] iavf: Fix out-of-bounds when setting channels on remove
Date: Wed, 3 May 2023 19:59:48 -0700 [thread overview]
Message-ID: <20230503195948.08e9ff1d@kernel.org> (raw)
In-Reply-To: <20230503082458.GH525452@unreal>
On Wed, 3 May 2023 11:24:58 +0300 Leon Romanovsky wrote:
> > + if (test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section))
> > + return -EOPNOTSUPP;
>
> This makes no sense without locking as change to __IAVF_IN_REMOVE_TASK
> can happen any time.
+1, the changes look questionable to me as well.
next prev parent reply other threads:[~2023-05-04 2:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 3:15 [PATCH net v4 0/2] iavf: Fix issues when setting channels concurrency with removing Ding Hui
2023-05-03 3:15 ` [PATCH net v4 1/2] iavf: Fix use-after-free in free_netdev Ding Hui
2023-05-03 3:15 ` [PATCH net v4 2/2] iavf: Fix out-of-bounds when setting channels on remove Ding Hui
2023-05-03 8:24 ` Leon Romanovsky
2023-05-03 14:00 ` Ding Hui
2023-05-03 16:29 ` Leon Romanovsky
2023-05-03 19:22 ` Chittim, Madhu
2023-05-04 7:57 ` Leon Romanovsky
2023-05-08 12:34 ` Ding Hui
2023-05-04 2:59 ` Jakub Kicinski [this message]
2023-05-03 19:26 ` [Intel-wired-lan] " Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503195948.08e9ff1d@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dinghui@sangfor.com.cn \
--cc=edumazet@google.com \
--cc=gregory.v.rose@intel.com \
--cc=grzegorzx.szczurek@intel.com \
--cc=huangcun@sangfor.com.cn \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhu.chittim@intel.com \
--cc=mateusz.palczewski@intel.com \
--cc=michal.kubiak@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengdonglin@sangfor.com.cn \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).