* [PATCH net] net: enetc: check the index of the SFI rather than the handle
@ 2023-05-04 8:03 wei.fang
2023-05-04 8:12 ` Leon Romanovsky
2023-05-05 8:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: wei.fang @ 2023-05-04 8:03 UTC (permalink / raw)
To: claudiu.manoil, davem, edumazet, kuba, pabeni, netdev; +Cc: linux-kernel
From: Wei Fang <wei.fang@nxp.com>
We should check whether the current SFI (Stream Filter Instance) table
is full before creating a new SFI entry. However, the previous logic
checks the handle by mistake and might lead to unpredictable behavior.
Fixes: 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 130ebf6853e6..83c27bbbc6ed 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -1247,7 +1247,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
int index;
index = enetc_get_free_index(priv);
- if (sfi->handle < 0) {
+ if (index < 0) {
NL_SET_ERR_MSG_MOD(extack, "No Stream Filter resource!");
err = -ENOSPC;
goto free_fmi;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: enetc: check the index of the SFI rather than the handle
2023-05-04 8:03 [PATCH net] net: enetc: check the index of the SFI rather than the handle wei.fang
@ 2023-05-04 8:12 ` Leon Romanovsky
2023-05-05 8:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2023-05-04 8:12 UTC (permalink / raw)
To: wei.fang
Cc: claudiu.manoil, davem, edumazet, kuba, pabeni, netdev,
linux-kernel
On Thu, May 04, 2023 at 04:03:59PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> We should check whether the current SFI (Stream Filter Instance) table
> is full before creating a new SFI entry. However, the previous logic
> checks the handle by mistake and might lead to unpredictable behavior.
>
> Fixes: 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: enetc: check the index of the SFI rather than the handle
2023-05-04 8:03 [PATCH net] net: enetc: check the index of the SFI rather than the handle wei.fang
2023-05-04 8:12 ` Leon Romanovsky
@ 2023-05-05 8:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-05 8:40 UTC (permalink / raw)
To: Wei Fang
Cc: claudiu.manoil, davem, edumazet, kuba, pabeni, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 4 May 2023 16:03:59 +0800 you wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> We should check whether the current SFI (Stream Filter Instance) table
> is full before creating a new SFI entry. However, the previous logic
> checks the handle by mistake and might lead to unpredictable behavior.
>
> Fixes: 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
>
> [...]
Here is the summary with links:
- [net] net: enetc: check the index of the SFI rather than the handle
https://git.kernel.org/netdev/net/c/299efdc2380a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-05 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-04 8:03 [PATCH net] net: enetc: check the index of the SFI rather than the handle wei.fang
2023-05-04 8:12 ` Leon Romanovsky
2023-05-05 8:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).