From: Jakub Kicinski <kuba@kernel.org>
To: Martin Wetterwald <martin@wetterwald.eu>
Cc: davem@davemloft.net, dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: ipconfig: Allow DNS to be overwritten by DHCPACK
Date: Thu, 4 May 2023 09:44:24 -0700 [thread overview]
Message-ID: <20230504094424.0458973d@kernel.org> (raw)
In-Reply-To: <CAFERDQ3hgA490w2zWmiDQu-HfA-DLWWkL4s8z4iZAPwPZvw=LA@mail.gmail.com>
On Thu, 4 May 2023 10:00:04 +0200 Martin Wetterwald wrote:
> +#ifdef IPCONFIG_DHCP
> + if (ic_nameservers[i] == NONE ||
> + ic_nameservers_fallback)
> +#else
> if (ic_nameservers[i] == NONE)
> +#endif
FWIW I'd vote to move the variable out of the #ifdef and avoid the hairy
code, it's just 4 bytes.
prev parent reply other threads:[~2023-05-04 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 10:06 [PATCH] net: ipconfig: Allow DNS to be overwritten by DHCPACK Martin Wetterwald
2023-05-03 10:13 ` Martin Wetterwald
2023-05-04 2:51 ` Jakub Kicinski
2023-05-04 8:00 ` [PATCH v2] " Martin Wetterwald
2023-05-04 8:39 ` Paolo Abeni
2023-05-04 16:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504094424.0458973d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=martin@wetterwald.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).