From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B226FAE for ; Fri, 5 May 2023 15:35:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB4C9C433D2; Fri, 5 May 2023 15:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683300933; bh=OPlunUdfvXK6uRgblU/QUedptc22mJhlsbSHxPNaQxs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uBEgDxn0+0bsBQOFEUNODO6ici04abrkTGxM1Ti7VAM95VsgFk2A0hHDwHKCokrS8 Mrr294E3dvqDcIRNgYol1IsU5EujK8O1Bob44G/BGBu1hsfmNh4OBqj2ndi5SdVWqy 5iWznbzqTVUTHsSD+XIIkJg+XW8ORTejSLrh1Strkj5/sTefdvMAohby9eElUbrgUG 6LUZ7KNWtiZC0/ZLdYpG/hFQ69ZlV//oirR09L+2v9j879UzQBu50mA9hpFpZg0/YA mgu0x7txicTMdWoyqHeqjH9oSLXHR/AkaAr/aKKT00tmV6uZuyiVbQF7nc2upziaPW S07MJj9QPSIjw== Date: Fri, 5 May 2023 08:35:31 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , poros , mschmidt , "netdev@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-clk@vger.kernel.org" , "Olech, Milena" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: <20230505083531.57966958@kernel.org> In-Reply-To: References: <20230417124942.4305abfa@kernel.org> <20230502083244.19543d26@kernel.org> <20230503191643.12a6e559@kernel.org> <20230504090401.597a7a61@kernel.org> <20230504114421.51415018@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 5 May 2023 12:41:11 +0200 Jiri Pirko wrote: > >connector label (i.e. front panel label)? Or also applicable to > >internal pins? It'd be easier to talk details if we had the user > >facing documentation that ships with these products. > > I think is is use case specific. Some of the pins face the user over > physical port, they it is a front panel label. Others are internal > names. I have no clue how to define and mainly enforce rules here. It should be pretty easy to judge if we see the user-facing documentation vendors have. > But as an example, if you have 2 pins of the same type, only difference > is they are connected to front panel connector "A" and "B", this is the > label you have to pass to the ID query. Do you see any other way? Sound perfectly fine, if it's a front panel label, let's call the attribute DPLL_A_PIN_FRONT_PANEL_LABEL. If the pin is not brought out to the front panel it will not have this attr. For other type of labels we should have different attributes.