From: Jakub Kicinski <kuba@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH 11/13] netdevice.h: Fix parentheses around macro parameter use
Date: Fri, 5 May 2023 11:44:45 -0700 [thread overview]
Message-ID: <20230505114445.49082b62@kernel.org> (raw)
In-Reply-To: <20230504200527.1935944-12-mathieu.desnoyers@efficios.com>
On Thu, 4 May 2023 16:05:25 -0400 Mathieu Desnoyers wrote:
> Add missing parentheses around macro parameter use in the following
> pattern:
>
> - "x - 1" changed for "(x) - 1",
> - "x->member" changed for "(x)->member".
>
> to ensure operator precedence behaves as expected.
>
> Remove useless parentheses around macro parameter use in the following
> pattern:
>
> - m((x), y) changed for m(x, y), because comma has the lowest operator
> precedence, which makes the extra comma useless.
Sure, why not. Can we take it via netdev, tho?
I can't have any dependencies, right?
next prev parent reply other threads:[~2023-05-05 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230504200527.1935944-1-mathieu.desnoyers@efficios.com>
2023-05-04 20:05 ` [RFC PATCH 11/13] netdevice.h: Fix parentheses around macro parameter use Mathieu Desnoyers
2023-05-05 18:44 ` Jakub Kicinski [this message]
2023-05-05 18:54 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230505114445.49082b62@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).