From: Leon Romanovsky <leon@kernel.org>
To: Simon Horman <simon.horman@corigine.com>, wuych <yunchuan@nfschina.com>
Cc: ioana.ciornei@nxp.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net:ethernet:freescale:dpaa2:Remove unnecessary (void*) conversions
Date: Sun, 7 May 2023 11:16:52 +0300 [thread overview]
Message-ID: <20230507081652.GE525452@unreal> (raw)
In-Reply-To: <ZFY0rlWDt1421Tvo@corigine.com>
On Sat, May 06, 2023 at 01:06:22PM +0200, Simon Horman wrote:
> On Sat, May 06, 2023 at 05:44:28PM +0800, wuych wrote:
> > Pointer variables of void * type do not require type cast.
> >
> > Signed-off-by: wuych <yunchuan@nfschina.com>
>
> Hi,
>
> this looks good, but a few things to improve:
>
> * Did you miss the instance in dpaa2_dbg_bp_show()
> * For networking patches, please set the target tree in the subject.
> As this is not a fix it should be 'net-next' (if it was a fix it would be
> 'net')
> [PATCH net-next v2] ...
> * As per the form letter below, -net-next is currently closed,
> so please repost after May 8th.
> * I think the subject prefix should be dpaa2-eth:
> [PATCH net-next v2] dpaa2: ...
> * I think the patch subject could be a bit clearer
> [PATCH net-next v2] dpaa2: Remove unnecessary cast of void pointers
Plus, another thing to consider is to take seriously feedback for other
patches https://lore.kernel.org/netdev/19409d2b4222b3a5c6fc0cedbfa7844b6eb3440f.camel@redhat.com/
Thanks
prev parent reply other threads:[~2023-05-07 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 9:44 [PATCH] net:ethernet:freescale:dpaa2:Remove unnecessary (void*) conversions wuych
2023-05-06 11:06 ` Simon Horman
2023-05-07 8:16 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230507081652.GE525452@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).