From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78AAE7C; Tue, 9 May 2023 01:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 780DDC433EF; Tue, 9 May 2023 01:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683596770; bh=LMdyy4IWImsK1SA4AwNEk1jXTLpVOax2pWupABnOyyE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ppo75Es8pZDmR2UJFCljfloHMxHGWgtxDW2pQAfDljVapDchuX6aM8fMgcXKQCi1G 7eIoD9NBJ63bpTqPyHoqICqWlezZNenHATl6ATLsvkqEckVxZOa2dhJmu3vXN3lHTe 3ik9h2LZUz067Dy9nMHnLSHCJhQBsRC4TL3GhZ8ph8TiuBtoVpqpooQEliBW2gdc+A A8jTE3ubntK545W76Lh3jgVjXSxWLPrXEKY9LzFd5riajDWI4QA+x5FrF1nr7HOVjX vvaNbfbtvEVVMGnM/IDGHmQMYplUWGrMbi3tgNH4xN+2FtRRAqI9IdwEUiGrA2e5AG tEmXfM7drYI3Q== Date: Mon, 8 May 2023 18:46:08 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: Wei Fang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Clark Wang , NXP Linux Team , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Gagandeep Singh Subject: Re: [RESEND PATCH v4 net 1/1] net: fec: correct the counting of XDP sent frames Message-ID: <20230508184608.43376a10@kernel.org> In-Reply-To: <20230508143831.980668-1-shenwei.wang@nxp.com> References: <20230508143831.980668-1-shenwei.wang@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 8 May 2023 09:38:31 -0500 Shenwei Wang wrote: > In the current xdp_xmit implementation, if any single frame fails to > transmit due to insufficient buffer descriptors, the function nevertheless > reports success in sending all frames. This results in erroneously > indicating that frames were transmitted when in fact they were dropped. > > This patch fixes the issue by ensureing the return value properly > indicates the actual number of frames successfully transmitted, rather than > potentially reporting success for all frames when some could not transmit. > > Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support") > Signed-off-by: Gagandeep Singh > Signed-off-by: Shenwei Wang Unfortunately the previous version was silently applied, it seems: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=26312c685ae0bca61e06ac75ee158b1e69546415 Could you send an incremental fix, on top of that patch? -- pw-bot: cr