Re: [PATCH v4 1/1] net: fec: correct the counting of XDP sent frames

[Leon Romanovsky <leon@kernel.org>]

On Mon, May 08, 2023 at 09:29:31AM -0500, Shenwei Wang wrote:
> In the current xdp_xmit implementation, if any single frame fails to
> transmit due to insufficient buffer descriptors, the function nevertheless
> reports success in sending all frames. This results in erroneously
> indicating that frames were transmitted when in fact they were dropped.
> 
> This patch fixes the issue by ensureing the return value properly
> indicates the actual number of frames successfully transmitted, rather than
> potentially reporting success for all frames when some could not transmit.
> 
> Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support")
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> ---
>  v4:
>   - the tx frame shouldn't be returned when error occurs.
>   - changed the function return values by using the standard errno.
> 
>  v3:
>   - resend the v2 fix for "net" as the standalone patch.
> 
>  v2:
>   - only keep the bug fix part of codes according to Horatiu's comments.
>   - restructure the functions to avoid the forward declaration.
> 
>  drivers/net/ethernet/freescale/fec_main.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

<...>

> -	for (i = 0; i < num_frames; i++)
> -		fec_enet_txq_xmit_frame(fep, txq, frames[i]);
> +	for (i = 0; i < num_frames; i++) {
> +		if (fec_enet_txq_xmit_frame(fep, txq, frames[i]) != 0)
> +			break;
> +		sent_frames++;
> +	}

net-next has commit 6312c685ae0 ("net: fec: correct the counting of XDP sent frames")
which has exactly these lines.

Plus the patch is missing target tree in its subject line.
For example: [PATCH net-next] ...

Thanks