* [PATCHv2 net] selftests: bonding: delete unnecessary line.
@ 2023-05-09 7:50 Liang Li
2023-05-09 7:52 ` Nikolay Aleksandrov
0 siblings, 1 reply; 2+ messages in thread
From: Liang Li @ 2023-05-09 7:50 UTC (permalink / raw)
To: netdev; +Cc: liali, j.vosburgh, razor, Hangbin Liu
"ip link set dev "$devbond1" nomaster"
This line code in bond-eth-type-change.sh is unnecessary.
Because $devbond1 was not added to any master device.
Fixes: 222c94ec0ad4("selftests: bonding: add tests for ether type changes")
Signed-off-by: Liang Li <liali@redhat.com>
Acked-by: Hangbin Liu <liuhangbin@gmail.com>
---
.../selftests/drivers/net/bonding/bond-eth-type-change.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
index 5cdd22048ba7..862e947e17c7 100755
--- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
+++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
@@ -53,7 +53,6 @@ bond_test_enslave_type_change()
# restore ARPHRD_ETHER type by enslaving such device
ip link set dev "$devbond2" master "$devbond0"
check_err $? "could not enslave $devbond2 to $devbond0"
- ip link set dev "$devbond1" nomaster
bond_check_flags "$devbond0"
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2 net] selftests: bonding: delete unnecessary line.
2023-05-09 7:50 [PATCHv2 net] selftests: bonding: delete unnecessary line Liang Li
@ 2023-05-09 7:52 ` Nikolay Aleksandrov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Aleksandrov @ 2023-05-09 7:52 UTC (permalink / raw)
To: Liang Li, netdev; +Cc: j.vosburgh, Hangbin Liu
On 09/05/2023 10:50, Liang Li wrote:
> "ip link set dev "$devbond1" nomaster"
> This line code in bond-eth-type-change.sh is unnecessary.
> Because $devbond1 was not added to any master device.
>
> Fixes: 222c94ec0ad4("selftests: bonding: add tests for ether type changes")
It doesn't fix anything because there really isn't a bug. The test still runs
as expected with the line below.
> Signed-off-by: Liang Li <liali@redhat.com>
> Acked-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> .../selftests/drivers/net/bonding/bond-eth-type-change.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> index 5cdd22048ba7..862e947e17c7 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> @@ -53,7 +53,6 @@ bond_test_enslave_type_change()
> # restore ARPHRD_ETHER type by enslaving such device
> ip link set dev "$devbond2" master "$devbond0"
> check_err $? "could not enslave $devbond2 to $devbond0"
> - ip link set dev "$devbond1" nomaster
>
> bond_check_flags "$devbond0"
>
I still think this patch should be targeted at net-next instead, the test
runs as expected with or without that line.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-09 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-09 7:50 [PATCHv2 net] selftests: bonding: delete unnecessary line Liang Li
2023-05-09 7:52 ` Nikolay Aleksandrov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).