From: Jakub Kicinski <kuba@kernel.org>
To: "Sokolowski, Jan" <jan.sokolowski@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: As usage of ethtool private flags is deprecated, what should we use from now on?
Date: Tue, 9 May 2023 08:50:21 -0700 [thread overview]
Message-ID: <20230509085021.3382222f@kernel.org> (raw)
In-Reply-To: <PH7PR11MB58196E41B57C8FFD30108B9399769@PH7PR11MB5819.namprd11.prod.outlook.com>
On Tue, 9 May 2023 11:15:57 +0000 Sokolowski, Jan wrote:
> So, as recently I've been trying to upstream a patch that would
> introduce a new private flag to i40e driver, I've received a note
> that, according to this reply from Jakub Kicinski
> (https://lore.kernel.org/netdev/20230207215643.43f76bdd@kernel.org/),
> the use of private flags is deprecated and is something that will not
> be accepted by upstream anymore.
It has little to do with ethtool private flags being deprecated
and a lot to do with how you were trying to use them. Andrew
explains it well.
Maybe we should have called them "my device is weird flags",
so people don't think they are "do whatever you want" flags :(
prev parent reply other threads:[~2023-05-09 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230310145100.1984-1-jan.sokolowski@intel.com>
[not found] ` <20230310145100.1984-2-jan.sokolowski@intel.com>
[not found] ` <99823d11-4c46-d105-aaa5-2d5da113627d@intel.com>
2023-05-09 11:15 ` As usage of ethtool private flags is deprecated, what should we use from now on? Sokolowski, Jan
2023-05-09 13:26 ` Andrew Lunn
2023-05-09 15:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509085021.3382222f@kernel.org \
--to=kuba@kernel.org \
--cc=jan.sokolowski@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).